Closed Bug 1728485 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 30203 - URLPattern: Fix matched values for ':name*' patterns.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30203 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30203
Details from upstream follow.

b'Ben Kelly <wanderview@chromium.org>' wrote:

URLPattern: Fix matched values for ':name*' patterns.

This fixes the problem where:

const p = new URLPattern({ pathname: ':name*' });
const r = p.exec('foobar');
console.log(r.pathname.groups.name);

Would log 'r' instead of 'foobar'.

This is an upstream bug in path-to-regexp as well:

https://github.com/pillarjs/path-to-regexp/issues/260

Fixed: 1243773
Change-Id: I402d2b8cba48386d9ae02a493068488a7ad91d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3123654
Commit-Queue: Ben Kelly \<wanderview@chromium.org>
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917069}

PR 30203 applied with additional changes from upstream: 168fb01517fe0d4ff5b39559c2e5d02ccc5aa4ff, dd1bd4510455460fbf7086faf340fb86f685fd5f, 90fa23d11bcc266e15d0a1d3198a9fb06c8d8e0f, 045e9f6cdc7daa1c70df21e08447a7274aba2277, 0c53a8cd1a1d508464168ed21bf12fd104aa8096, 3a3861a77c2a76eb2250aa73261c0eb6901c383f, c472b505c61ab279a3d28079fa0a5c40fe3ba600
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/591d938dbf88
[wpt PR 30203] - URLPattern: Fix matched values for ':name*' patterns., a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.