1728510 - Close button disappears when sidebar is open

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Outvi V]

Attachment: Illustrates the bug.

STR:

1. Open find bar by Ctrl-F
2. Open sidebar by Ctrl-B
3. The close button disappears

Verified on Nightly 93.0a1 2021-08-31. Regression info given by bisect.

Comment 1

[Outvi V]

Regressed by Bug 1724194.

Also I noticed that if the findbar and sidebar are opened and then widen the window, the close button will be visible sometimes.

Comment 2

[Alice0775 White]

I can reproduce the issue on Windows10.

Comment 3

[Alice0775 White]

Bug 1728368 fixes this issue on Nightly93.0a1 (20210901091701) Windows10 and Ubuntu20.04.

Comment 4

[Daniel Bodea [:danibodea]]

I can also confirm that this issue is reproducing on Windows 10 and Ubuntu 20 on Beta 92.0RC and older Nightlies; Furthermore, I can also confirm the fix in Nightly v93.0a1 from 2021-09-03.
I have to say that the issue can't be verified as it does not reproduce on Mac OS since the "X" button is on the left side of the find bar, not the right.

I've set the Resolved status based on the last comments. This issue will probably be fixed in upper channels as well considering the uplift request in bug 1728368, so I won't be setting it as verified just yet.

Comment 5

[Daniel Bodea [:danibodea]]

Mozregression "find fix" results:
2021-09-03T16:26:03.925000: DEBUG : Found commit message:
Bug 1728368 - Simplify findbar overflow behavior. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D124086
2021-09-03T16:26:03.925000: DEBUG : Did not find a branch, checking all integration branches
2021-09-03T16:26:03.927000: INFO : The bisection is done.

Comment 8

[bughit]

Why doesn't this justify a 92.0.1?