1728580 - If Firefox was dragged to the Dock from DMG, subsequent installation from DMG results in second Dock icon

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Stephen A Pohl [:spohl]]

If Firefox was dragged from the DMG straight to the Dock and the user subsequently chooses to install Firefox to /Applications using our prompt from bug 516362, the installation will result in a second Firefox icon being pinned right next to the first, user-created one. The first icon will continue to point to Firefox inside the DMG. The second one will point to Firefox in /Applications.

STR:

1. Download Nightly.
2. Open the .dmg
3. Drag "Firefox Nightly" to the Dock.
4. Double click the "Firefox Nightly" icon in the .dmg folder, or click the icon in the Dock.
5. When the "Install Firefox" dialog appears, select "Install"

Expected results:
There should only be one icon in the Dock, pointing to the newly installed Firefox .app bundle in /Applications.

Actual results:
Two icons in the Dock. The first one pointing to Firefox inside the DMG. The second one pointing to Firefox in /Applications.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Bug 1728580: Support replacing of an existing Dock icon during pinning on macOS if the first icon is pointing to an app inside a DMG. r=mstange

Depends on D123899

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d28a7b6edac6
Support replacing of an existing Dock icon during pinning on macOS if the first icon is pointing to an app inside a DMG. r=mstange

Comment 3

[Andreea Pavel [:apavel]]

Backed out for windows build bustages

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d28a7b6edac6cd5407fd24c177d4984b7080de94&selectedTaskRun=fcKnPKZFRBSYK-FN6wWq9Q.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=350364884&repo=autoland&lineNumber=36563

Backout: https://hg.mozilla.org/integration/autoland/rev/708683349118cc869da8ac0bd3710e107e142df4

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1888810107ca
Support replacing of an existing Dock icon during pinning on macOS if the first icon is pointing to an app inside a DMG. r=mstange

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1888810107ca