Closed
Bug 1728605
Opened 3 years ago
Closed 3 years ago
Clean up some inconsistent method naming on WindowContext/BrowsingContext
Categories
(Core :: DOM: Navigation, task, P3)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
93 Branch
Tracking | Status | |
---|---|---|
firefox93 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
Details
Attachments
(3 files)
No description provided.
Assignee | ||
Comment 1•3 years ago
|
||
These codepaths will never be taken with SHIP enabled, and this patch adds a
couple assertions to keep track of that information for when we rip out SHIP.
Assignee | ||
Comment 2•3 years ago
|
||
This method actually tracks whether the context is current, so it has been
renamed, and the behaviour has been inverted.
Depends on D124210
Assignee | ||
Comment 3•3 years ago
|
||
This makes the method's name more consistent with IsContentSubframe, and is
probably more clear than IsFrame (as a <browser> could be considered a frame).
Depends on D124211
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62e758932f64
Part 1: Add assertions to various non-SHIP codepaths, r=smaug
https://hg.mozilla.org/integration/autoland/rev/52fab476b34c
Part 2: Rename misleading {Window,Browsing}Context::IsCached, r=smaug
https://hg.mozilla.org/integration/autoland/rev/7cb6b2b14554
Part 3: Rename IsFrame to IsSubframe, r=smaug
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/62e758932f64
https://hg.mozilla.org/mozilla-central/rev/52fab476b34c
https://hg.mozilla.org/mozilla-central/rev/7cb6b2b14554
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•