Closed Bug 1728706 Opened 3 months ago Closed 3 months ago

use IsRootContentDocumentInProcess for top layer related optimization in ScrollFrameHelper::BuildDisplayList

Categories

(Core :: Web Painting, task)

task

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.

The reason this IsRootContentDocument check was added was because of a test where there is fixed pos content in the top layer of a subdocument. This fixed pos content gets removed from the display list as part of this optimization. So no WebRenderLayerScrollData gets created for the asr of this fixed pos content, which causes an assert. (from https://bugzilla.mozilla.org/show_bug.cgi?id=1664804#c18 )

It seems like this scenario could happen at the root of a fission oop if child process too, so we should be checking IsRootContentDocumentCrossProcess here. That should still catch the main cases we care about for this optimization.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ba31a6b4959
Use IsRootContentDocumentCrossProcess for top layer related optimization in ScrollFrameHelper::BuildDisplayList. r=botond
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Summary: use IsRootContentDocumentCrossProcess for top layer related optimization in ScrollFrameHelper::BuildDisplayList → use IsRootContentDocumentInProcess for top layer related optimization in ScrollFrameHelper::BuildDisplayList
You need to log in before you can comment on or make changes to this bug.