172874 - cvs remove attachstatus templates

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Gervase Markham [:gerv]]

editattachstatuses.cgi has gone, but the templates in
template/en/default/attachment remain.

Gerv

Comment 1

[Gervase Markham [:gerv]]

myk: ping? I can't ask for a review here, because the old Request Tracker
doesn't allow review of bugs. Basically, this just needs your approval - it
seems pretty obvious.

Gerv

Comment 2

[Myk Melez [:myk] [@mykmelez]]

r=myk, make it so.

Comment 3

[Gervase Markham [:gerv]]

Fixed.

Removing content-types.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/content-types.html.tmpl,v
 <--  content-types.html.tmpl
new revision: delete; previous revision: 1.1
done
Removing create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v
 <--  create.html.tmpl
new revision: delete; previous revision: 1.10
done
Removing created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/created.html.tmpl,v
 <--  created.html.tmpl
new revision: delete; previous revision: 1.5
done
Removing edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: delete; previous revision: 1.12
done
Removing list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v
 <--  list.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v
 <--  show-multiple.html.tmpl
new revision: delete; previous revision: 1.6
done
Removing updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/updated.html.tmpl,v
 <--  updated.html.tmpl
new revision: delete; previous revision: 1.5
done

Gerv

Comment 4

[Dave Miller [:justdave]]

This has been backed out.  Tinderbox is burning.

not ok 12 - template/en/default/attachment/show-multiple.html.tmpl does not
exist --ERROR
#     Failed test (t/004template.t at line 67)
not ok 13 - template/en/default/attachment/create.html.tmpl does not exist --ERROR
#     Failed test (t/004template.t at line 67)
not ok 14 - template/en/default/attachment/created.html.tmpl does not exist --ERROR
#     Failed test (t/004template.t at line 67)
not ok 15 - template/en/default/attachment/edit.html.tmpl does not exist --ERROR
#     Failed test (t/004template.t at line 67)
not ok 16 - template/en/default/attachment/updated.html.tmpl does not exist --ERROR
#     Failed test (t/004template.t at line 67)


The list of template files searched for is generated by scanning the code
looking for references to them.  This means something somewhere is still
referencing these templates, therefore they can't be removed.

Comment 5

[Bradley Baetz (:bbaetz)]

/me thinks gerv meant to remove teh stuff in admin, instead

Comment 6

[Gervase Markham [:gerv]]

*&%$£*!?!. 

So, Bugzilla doesn't work properly after removing a load of vital templates? Who
would have thought it? 

To be fair, I removed exactly the templates that comment 0 said I would...

Let's try again:

Removing create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/attachstatus/create.html.tmpl,v
 <--  create.html.tmpl
new revision: delete; previous revision: 1.3
done
Removing delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/attachstatus/delete.html.tmpl,v
 <--  delete.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/attachstatus/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: delete; previous revision: 1.4
done
Removing list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/attachstatus/list.html.tmpl,v
 <--  list.html.tmpl
new revision: delete; previous revision: 1.5
done

Gerv

Comment 7

[Dave Miller [:justdave]]

Tinderbox has cycled and is still green.  Good deal :)