1728769 - Consider using `std::underlying_type_t` for the profiler buffer types

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Currently we have some types that we use in the buffer like ...UnderlyingType. It would be great to remove them and directly use std::underlying_type_t instead in the future.

See the locations where we have these types:
https://searchfox.org/mozilla-central/search?q=using.*UnderlyingType&path=profiler&case=false&regexp=true

Comment 1

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

I'm not sure this transform is valid for the UnderlyingType in ProportionValue.h, as it isn't an enum class. We could potentially restructure it to make it so, but I don't know what value that would add as the typedef isn't used outside of ProportionValue.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

(In reply to Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT from comment #1)

I'm not sure this transform is valid for the UnderlyingType in ProportionValue.h, as it isn't an enum class. We could potentially restructure it to make it so, but I don't know what value that would add as the typedef isn't used outside of ProportionValue.

Yes, you're right. I think when I wrote this bug and added this searchfox link, that type didn't exist yet. Let's leave that type out of this bug's scope.

Comment 3

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Sounds good. I'm mostly done with the refactoring, so should hopefully have a patch up today.

Comment 4

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1728769 - Use std::underlying_type_t for profile buffer enum types r=canaltinova

This patch replaces "custom" underlying type definitions with definitions gleaned using the std::underlying_type mechanism. This allows us to directly set the underlying type for the enums without having to name it, and reduces the number of semantically identical names in the profile buffer code.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a997d78debb4
Use std::underlying_type_t for profile buffer enum types r=canaltinova

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a997d78debb4