6.71 - 3.52% displaylist_mutate / displaylist_mutate + 2 more (Linux, OSX) regression on Tue August 31 2021
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox-esr91 | --- | unaffected |
| firefox91 | --- | unaffected |
| firefox92 | --- | unaffected |
| firefox93 | --- | fixed |
People
(Reporter: aesanu, Assigned: gw)
References
(Regression)
Details
(4 keywords)
Attachments
(1 file)
Perfherder has detected a talos performance regression from push e567052f6153e252eff9f91903a65ad1b657bf85. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 7% | displaylist_mutate | linux1804-64-shippable-qr | e10s stylo webrender-sw | 2,320.15 -> 2,475.81 |
| 6% | displaylist_mutate | linux1804-64-shippable-qr | e10s stylo webrender-sw | 2,358.38 -> 2,500.78 |
| 4% | displaylist_mutate | macosx1015-64-shippable-qr | e10s stylo webrender | 1,953.55 -> 2,024.23 |
| 4% | displaylist_mutate | macosx1015-64-shippable-qr | e10s stylo webrender-sw | 1,967.62 -> 2,036.82 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.
For more information on performance sheriffing please see our FAQ.
|
Assignee | |
Comment 1•3 years ago
|
||
This is unexpected - I'll investigate today.
|
||
Comment 2•3 years ago
|
||
I think this is most likely caused by DisplayItemCache being broken somehow. Enabling debug stats locally shows that no items are getting reused.
|
|
Assignee | |
Comment 3•3 years ago
|
||
I think you're right - the debug stats there are definitely different before / after that patch, thanks!
|
|
Assignee | |
Comment 4•3 years ago
|
||
Fix a bug where the display item cache was not being reused from
frame to frame with retained display list builders.
At the same time, make the capacity recycling on the display list
serialization arrays a bit more realistic.
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a480a8364911 Fix display item cache with retained DL builder. r=miko,gfx-reviewers
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
|
||
Comment 7•3 years ago
|
||
Set release status flags based on info from the regressing bug 1727458
|
Reporter | |
Comment 8•3 years ago
|
||
== Change summary for alert #31172 (as of Mon, 06 Sep 2021 08:15:58 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 6% | displaylist_mutate | linux1804-64-shippable-qr | e10s stylo webrender-sw | 2,470.09 -> 2,324.70 |
| 5% | displaylist_mutate | macosx1015-64-shippable-qr | e10s stylo webrender | 2,042.00 -> 1,938.72 |
| 4% | displaylist_mutate | macosx1015-64-shippable-qr | e10s stylo webrender-sw | 2,039.64 -> 1,959.12 |
| 3% | displaylist_mutate | macosx1015-64-shippable-qr | e10s stylo webrender-sw | 2,041.06 -> 1,970.30 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=31172
|
||
Updated•3 years ago
|
Description
•