1728798 - Print original error stack in the shell instead of the pending exception stack

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

finally blocks call setPendingExceptionAndCaptureStack(), which overwrites the pending exception stack. This leads to showing the wrong stack in the shell.

This is a regression from bug 1547131.

---

The stack trace points to the finally block instead of the call.

Test case 1:

function throwError() {
  throw new Error();
}

try {
  throwError();
} finally {
}

Expected:

/tmp/d.js:2:9 Error: 
Stack:
  throwError@/tmp/d.js:2:9
  @/tmp/d.js:6:3

Actual:

/tmp/d.js:2:9 Error: 
Stack:
  @/tmp/d.js:7:11

---

Super confusing in for-of loops when the stack line number points to non-throwing operation.

Test case 2:

function throwError() {
  throw new Error();
}

for (var v of [0]) {
  throwError();

  v = 1;
}

Expected:

/tmp/d.js:2:9 Error: 
Stack:
  throwError@/tmp/d.js:2:9
  @/tmp/d.js:6:3

Actual:

/tmp/d.js:2:9 Error: 
Stack:
  @/tmp/d.js:8:3

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1728798: Print original error stack in the shell instead of the pending exception stack. r=jandem!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6b35ebab6d6
Print original error stack in the shell instead of the pending exception stack. r=jandem

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f6b35ebab6d6