Closed Bug 1728839 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30306 - [layout] Remove limit from LayoutInline::SplitInlines.

Categories

(Core :: Layout: Block and Inline, task, P4)

Product:
Core
Component:
Layout: Block and Inline
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30306 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30306
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[layout] Remove limit from LayoutInline::SplitInlines.

After 200 elements the code "gave up" causing the layout tree to be
"strange".

This caused a To\<LayoutInline> to fail in the OOF code. Relaxing this
To\<> to a DynamicTo\<> caused additional CHECKs / DCHECKs all over the
place (not just in NG but in Legacy as well).

This patch removes the limit at which we "give up". This may cause
additional render hangs.

However we currently have a project "block-in-inline" which will (for
most cases) stop inline-splitting for occuring (except in legacy
fallback).

Bug: 1245786
Change-Id: I5f1c4d6a4b81a8345974de40c0c50a27a839b7b4

Reviewed-on: https://chromium-review.googlesource.com/3140144
WPT-Export-Revision: 80e2643b405991990a34246c57d3a72b1160d3cd

Component: web-platform-tests → Layout: Block and Inline
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f1d9c580105
[wpt PR 30306] - [layout] Remove limit from LayoutInline::SplitInlines., a=testonly

https://hg.mozilla.org/mozilla-central/rev/5f1d9c580105

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.