Closed Bug 1728841 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 30308 - Revert "Fix test picture generation and add test."

Categories

(Core :: WebRTC, task, P4)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30308 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30308
Details from upstream follow.

b'Yi Xu <yiyix@chromium.org>' wrote:

Revert "Fix test picture generation and add test."

This reverts commit 84222e05b7a97c034e40d2d118de4aac05a94c50.

Reason for revert: caused test to fail external/wpt/webrtc/RTCPeerConnection-helper-test.html, ex build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests

Bug: 1245692
Original change's description:

Fix test picture generation and add test.

This CL changes the test picture from a growing box to a small moving
box. It adds a test that the expected bandwidth target is achieved at
the expected resolution.

In a browser, 640x480 is not reached within 5 seconds. This is odd.

Bug: None.
Change-Id: I2d94f1c190c26cec6759ecc0f788feea8e52ed7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3135833
Commit-Queue: Harald Alvestrand \<hta@chromium.org>
Reviewed-by: Florent Castelli \<orphis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917211}

Bug: None.
Change-Id: I205c46cca2245f3f906d52cca87ad878b486ee82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3137553
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Kevin Marshall \<kmarshall@chromium.org>
Reviewed-by: Harald Alvestrand \<hta@chromium.org>
Commit-Queue: Harald Alvestrand \<hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917317}

PR 30308 applied with additional changes from upstream: ed9b278329b48455b62195b32be8aa0f40812de5, fb595c54c13e1dc40b9f8e68016079164114e8fd
Component: web-platform-tests → WebRTC
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7bef4faf0a1
[wpt PR 30308] - Revert "Fix test picture generation and add test.", a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.