[wpt-sync] Sync PR 30310 - Do not access a null optional for text-decorations
Categories
(Core :: Layout: Text and Fonts, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 30310 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/30310
Details from upstream follow.
b'Stephen Chenney <schenney@chromium.org>' wrote:
Do not access a null optional for text-decorations
The TextDecorationInfo::ComputeDecorationThickness method
assumed that the font always had a non-null UnderlineThickness.
But a zero sized font has a nullopt for UnderlineThickness and
we would crash when trying to get the thickness for decorations.Refactor the code to check for null thickness data.
Add a WPT test.
Bug: 1244319
Change-Id: Ibc7dc1a9869e982d8398f9d3f7a20d447040a5b5
Reviewed-on: https://chromium-review.googlesource.com/3138622
WPT-Export-Revision: e3762c2a4b191eacaf6c252ef0776625bd197816
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ace4e3b9a7c1256586ecd6d11fc4e49eeb642ab
|
|
Assignee | |
Comment 2•3 years ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS : 1
Chrome
CRASH: 1
Safari
PASS : 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5ecc1c77c75 [wpt PR 30310] - Do not access a null optional for text-decorations, a=testonly
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Description
•