Closed Bug 1728917 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30319 - [WebCodecs] Prevent deeply nested frames.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox94 fixed)

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30319 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30319
Details from upstream follow.

b'Dale Curtis <dalecurtis@chromium.org>' wrote:

[WebCodecs] Prevent deeply nested frames.

It's not correct to directly access the wrapped frame since it may
itself be wrapping another frame. Prevent nesting, but also switch
call sites to not operate directly on |wrapped_frame_| for ease of
reasoning.

R=sandersd

Fixed: 1246173
Change-Id: I1475aa695a1801620eebdcb88a0d421652696261
Reviewed-on: https://chromium-review.googlesource.com/3140495
WPT-Export-Revision: bd8d2ddbdaad5a83969a41158ea9401a36d55335

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
FAIL: 14

Chrome

OK : 2
PASS: 14

Safari

OK : 2
FAIL: 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/videoFrame-drawImage.any.worker.html
drawImage(VideoFrame) with canvas(48x36 srgb uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(480x360 srgb uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(48x36 display-p3 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(480x360 display-p3 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(48x36 rec2020 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage on a closed VideoFrame throws InvalidStateError.: FAIL (Chrome: PASS, Safari: FAIL)
drawImage of nested frame works properly: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/videoFrame-drawImage.any.html
drawImage(VideoFrame) with canvas(48x36 srgb uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(480x360 srgb uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(48x36 display-p3 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(480x360 display-p3 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(48x36 rec2020 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage on a closed VideoFrame throws InvalidStateError.: FAIL (Chrome: PASS, Safari: FAIL)
drawImage of nested frame works properly: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/467c2c1baa82
[wpt PR 30319] - [WebCodecs] Prevent deeply nested frames., a=testonly
https://hg.mozilla.org/integration/autoland/rev/aff0bc45eac6
[wpt PR 30319] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/467c2c1baa82
https://hg.mozilla.org/mozilla-central/rev/aff0bc45eac6

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.