Closed Bug 1728938 Opened 5 months ago Closed 5 months ago

Restore "save password" check boxes in prompts after bug 1676216

Categories

(Thunderbird :: Upstream Synchronization, defect, P1)

Tracking

(thunderbird_esr91 unaffected, thunderbird92 unaffected)

RESOLVED FIXED
93 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird92 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(2 files)

Bug 1676216 took the option for check boxes out of nsIPrompt and nsIPromptService, but we use those options for mail protocol authentication. In this bug I'll restore the check boxes in those prompts by going around the interfaces and opening the prompts directly.

It's possible we could do something better than these prompts, but let's decide that for ourselves when we are ready to.

Keywords: leave-open
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/1ed6dbbb95c2
Port bug 1676216 changes to nsIPromptService, to unbreak the Windows build. rs=bustage-fix

This patch adds our own implementation of nsIAuthPrompt, which opens prompts that have 'save password' check boxes.

I haven't fixed CardDAV or calendar auth yet, just skipped the one test that relies on saving not happening automatically.

Depends on: 1676216
Target Milestone: --- → 93 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/a2fce42fe403
Reinstate check boxes in password prompts after bug 1676216. r=mkmelin

Attachment #9239559 - Attachment description: Bug 1728938 - Reinstate check boxes in password prompts for address books and calendars. r=mkmelin → Bug 1728938 - Reinstate check boxes in password prompts for address books and calendars. r=mkmelin
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a068a822c17c
Fix a few mistakes. rs=me DONTBUILD

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/a958db3428f7
Reinstate check boxes in password prompts for address books and calendars. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.