1728938 - Restore "save password" check boxes in prompts after bug 1676216

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect, P1)

Description

[Geoff Lankow (:darktrojan)]

Bug 1676216 took the option for check boxes out of nsIPrompt and nsIPromptService, but we use those options for mail protocol authentication. In this bug I'll restore the check boxes in those prompts by going around the interfaces and opening the prompts directly.

It's possible we could do something better than these prompts, but let's decide that for ourselves when we are ready to.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ed6dbbb95c2
Port bug 1676216 changes to nsIPromptService, to unbreak the Windows build. rs=bustage-fix

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1728938 - Reinstate check boxes in password prompts after bug 1676216. r=mkmelin

This patch adds our own implementation of nsIAuthPrompt, which opens prompts that have 'save password' check boxes.

Comment 3

[Geoff Lankow (:darktrojan)]

I haven't fixed CardDAV or calendar auth yet, just skipped the one test that relies on saving not happening automatically.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a2fce42fe403
Reinstate check boxes in password prompts after bug 1676216. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1728938 - Reinstate check boxes in password prompts for address books and calendars. r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a068a822c17c
Fix a few mistakes. rs=me DONTBUILD

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a958db3428f7
Reinstate check boxes in password prompts for address books and calendars. r=mkmelin