Closed Bug 1728955 Opened 3 years ago Closed 3 years ago

Improve logging in Windows-specific clipboard code

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)

References

Details

Attachments

(8 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Helps to fix bug 1726269 and prospective fixes, too.

The flags contain names of old contributers, which makes them inconvient
to use. Now it's also possible to simply enable logging for release
builds.

Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a606364e15c5
part 1) Remove ancient compile time flags for Windows' Clipboard logging. r=masayuki

This doesn't handle the error, but at least increases chances to become
aware of it.

Depends on D124756

Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5ca18235f11
part 2) Add more logging to Windows-specific clipboard code. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/7e7345ede64d
part 3) Add logging to `nsBaseClipboard`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/f97f21f46037
part 4) Add logging for some cases when `nsBaseClipboard::SetData` fails. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/4dc199dadc4d
part 5) Add missing `// static` comment to `nsClipboard::CreateNativeDataObject`. r=masayuki

Backed out for causing build bustages on nsBaseClipboard.cpp
Backout link
Push with failures
Failure Log

Flags: needinfo?(mbrodesser)

Thanks for the ni?-request. Should be corrected now.

Flags: needinfo?(mbrodesser)
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8976ce656ea
part 2) Add more logging to Windows-specific clipboard code. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/8c0d7aa52fde
part 3) Add logging to `nsBaseClipboard`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/1f199996819f
part 4) Add logging for some cases when `nsBaseClipboard::SetData` fails. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/192384798006
part 5) Add missing `// static` comment to `nsClipboard::CreateNativeDataObject`. r=masayuki
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39df361661c0
part 6) Log result of Windows' `OleSetClipboardResult`. r=masayuki
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c97f6d226d1
part 7) Log result of Windows' `OleGetClipboardResult` . r=masayuki

It's clearer and when logging is disabled, this is now more efficient.

Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0408d0034456
part 8) Refactor `DisplayErrCode` in Windows' `nsClipboard`. r=masayuki
Status: NEW → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: