1728974 - TypeError: can't access property "browserId", topFrame.browsingContext is null

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Rob Wu [:robwu]]

I see this error very often in my browser console:

TypeError: can't access property "browserId", topFrame.browsingContext is null
    matchRequest resource://devtools/server/actors/network-monitor/network-observer.js:126
    _httpResponseExaminer resource://devtools/server/actors/network-monitor/network-observer.js:450
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103

Error reported by:

ThreadSafeDevToolsUtils.js:82:13
    reportException resource://devtools/shared/ThreadSafeDevToolsUtils.js:82
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:109

I don't know how exactly it happened, but I can tell that I open the developer tools very often (tab's devtools, extension debugger, Browser Toolbox, Browser Content Toolbox, Browser Console).

The error is thrown from https://searchfox.org/mozilla-central/rev/55e8eba74b60b92d04b781f7928f54ef76b13fa9/devtools/server/actors/network-monitor/network-observer.js#126

It looks like the browsingContext attribute may be null:
https://searchfox.org/mozilla-central/rev/55e8eba74b60b92d04b781f7928f54ef76b13fa9/dom/webidl/MozFrameLoaderOwner.webidl#35
https://searchfox.org/mozilla-central/rev/55e8eba74b60b92d04b781f7928f54ef76b13fa9/dom/base/nsFrameLoaderOwner.cpp#42-47

... so a fix could be to replace topFrame.browsingContext.browserId with topFrame.browsingContext?.browserId

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for filing, let's apply the suggestion

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1728974 - [devtools] Avoid exceptions when processing requests of tabs being closed.

This doesn't reproduce easily. But you may see that while closing a youtube page
while having the browser console opened.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f050e5cd7e81
[devtools] Avoid exceptions when processing requests of tabs being closed. r=bomsy

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f050e5cd7e81