Drop esr78 from cross-channel configuration
Categories
(Mozilla Localizations :: Other, task)
Tracking
(firefox94 fixed)
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
Details
Attachments
(2 files, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
507.38 KB,
patch
|
Details | Diff | Splinter Review |
While 78 will be supported for another release, there's no plan to update localization on those branch, and it's time to get rid of a lot of strings by dropping esr78 for both mozilla and comm repos.
Assignee | ||
Comment 1•3 years ago
|
||
This is not exactly trivial to test locally, but you can prep and run the content generation via
./mach l10n-cross-channel prep
./mach l10n-cross-channel create
It should create an en-US
folder within your mozilla-unified clone, and you can inspect the latest commit. Note it's going to take a while to finish (almost 30 minutes in a VM not particularly powerful).
Attached is the resulting diff.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Somehow the first file doesn't work correctly on top of the quarantine repository.
Assignee | ||
Updated•3 years ago
|
Comment 4•3 years ago
|
||
Is the esr78
end-of-support documented somewhere? I went looking, but could not find a reference for that.
In the diff, a couple of messages in netwerk/necko.properties
and security/manager/chrome/pippki/pippki.properties
appear to lose a trailing space (or maybe a \r
before the \n
). Is that intentional?
Finally, is cleanup expected to happen at some point for message ids that previously ended up with a numeric 2
or 3
suffix, but for which the first message version is dropped, as happens here a couple of times?
Assignee | ||
Comment 5•3 years ago
|
||
(In reply to Eemeli Aro [:eemeli] from comment #4)
Is the
esr78
end-of-support documented somewhere? I went looking, but could not find a reference for that.
The current ESR is 91, support for the previous ESR (78) gets dropped after 2 cycles of the new ESR (when 91.2 is released). They basically overlap for 2 cycles (see picture here). This page has all the release dates: https://wiki.mozilla.org/Release_Management/Calendar
Note that dropping support in cross-channel doesn't mean that we can't have more ESR78 builds. The list of changesets used to create those builds is not updated automatically
https://hg.mozilla.org/releases/mozilla-esr78/file/tip/browser/locales/l10n-changesets.json
It only means that we can't update localizations for ESR78, which we wouldn't do anyway.
In the diff, a couple of messages in
netwerk/necko.properties
andsecurity/manager/chrome/pippki/pippki.properties
appear to lose a trailing space (or maybe a\r
before the\n
). Is that intentional?
That looks like compare-locales merge logic picking up changes that indeed landed
https://hg.mozilla.org/mozilla-central/rev/2b4dde8c9c1e6bf81a4351aad7b3d10372b9a771
Finally, is cleanup expected to happen at some point for message ids that previously ended up with a numeric
2
or3
suffix, but for which the first message version is dropped, as happens here a couple of times?
Can you clarify what you mean with cleanup? If it's about l10n repositories, I do run a script periodically to remove obsolete strings.
Comment 6•3 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #5)
(In reply to Eemeli Aro [:eemeli] from comment #4)
The current ESR is 91, support for the previous ESR (78) gets dropped after 2 cycles of the new ESR (when 91.2 is released). They basically overlap for 2 cycles (see picture here). This page has all the release dates: https://wiki.mozilla.org/Release_Management/Calendar
Ok. I guess I was looking for something like this: https://nodejs.org/en/about/releases/
In other words, a page that says that support will end on date X, rather than a description of the process that generates that date. It doesn't look like such currently exists.
Finally, is cleanup expected to happen at some point for message ids that previously ended up with a numeric
2
or3
suffix, but for which the first message version is dropped, as happens here a couple of times?Can you clarify what you mean with cleanup? If it's about l10n repositories, I do run a script periodically to remove obsolete strings.
I meant renaming the keys to drop the now-obsolete numeric suffix. Or does that not happen?
Assignee | ||
Comment 7•3 years ago
|
||
(In reply to Eemeli Aro [:eemeli] from comment #6)
In other words, a page that says that support will end on date X, rather than a description of the process that generates that date. It doesn't look like such currently exists.
No, I'm not aware of such a page.
I meant renaming the keys to drop the now-obsolete numeric suffix. Or does that not happen?
No, that doesn't happen because it would require all locales to retranslate those strings.
Pushed by flodolo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/295a38fd9261 Drop esr78 from cross-channel generation, r=eemeli
Comment 9•3 years ago
|
||
bugherder |
Description
•