Closed Bug 1729009 Opened 3 years ago Closed 3 years ago

Make more requests in remote settings use beConservative

Categories

(Firefox :: Remote Settings Client, enhancement)

Product:
Firefox
Component:
Remote Settings Client
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mixedpuppy, Assigned: robwu)

References

Details

Attachments

(1 file)

Bug 1729009 - Improve reliability of attachment downloader + tests
48 bytes, text/x-phabricator-request
Details | Review

In Bug 1654693 the first polling request was switched to use beConservative. However, the data fetches in Attachments.jsm still use fetch, thus beConservative is not set. We need to switch those over to using ServiceRequest.

Assignee: nobody → rob
Status: NEW → ASSIGNED

  • Replace services.settings.server pref with Utils.SERVER_URL for
    consistency with the whole RemoteSettings client.

  • Replace fetch with Utils.fetch to fetch more reliably.

  • Change implementation of Utils.fetch to not mangle the response,
    which would particularly be problematic for binary attachments.

Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/9a0ea53a7618
Improve reliability of attachment downloader + tests r=leplatrem

https://hg.mozilla.org/mozilla-central/rev/9a0ea53a7618

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
See Also: → 1734396
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: