Closed Bug 1729029 Opened 3 years ago Closed 3 years ago

Perma TEST-UNEXPECTED-PASS | /wasm/jsapi/function/constructor.tentative.any.worker.html | fail with missing results - expected FAIL when Gecko 93 merges to Beta on 2021-09-06

Categories

(Core :: JavaScript: WebAssembly, defect, P1)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox91 --- unaffected
firefox92 --- unaffected
firefox93 + fixed
firefox94 --- verified

People

(Reporter: nataliaCs, Assigned: rhunt)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Bug 1729029 - Ensure test fails when feature is off; r=lth
48 bytes, text/x-phabricator-request
Details | Review

[Tracking Requested - why for this release]:

[task 2021-09-03T13:26:31.891Z] 13:26:31     INFO - TEST-FAIL | /wasm/jsapi/function/constructor.tentative.any.worker.html | construct with JS function - WebAssembly.Function is not a constructor
[task 2021-09-03T13:26:31.891Z] 13:26:31     INFO - @http://web-platform.test:8000/wasm/jsapi/function/constructor.tentative.any.js:9:15
[task 2021-09-03T13:26:31.891Z] 13:26:31     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2087:25
[task 2021-09-03T13:26:31.892Z] 13:26:31     INFO - test@http://web-platform.test:8000/resources/testharness.js:557:30
[task 2021-09-03T13:26:31.892Z] 13:26:31     INFO - @http://web-platform.test:8000/wasm/jsapi/function/constructor.tentative.any.js:8:5
[task 2021-09-03T13:26:31.892Z] 13:26:31     INFO - @http://web-platform.test:8000/wasm/jsapi/function/constructor.tentative.any.worker.js:8:14
[task 2021-09-03T13:26:31.892Z] 13:26:31     INFO - TEST-UNEXPECTED-PASS | /wasm/jsapi/function/constructor.tentative.any.worker.html | fail with missing results - expected FAIL
[task 2021-09-03T13:26:31.892Z] 13:26:31     INFO - TEST-INFO | expected FAIL
[task 2021-09-03T13:26:31.893Z] 13:26:31     INFO - 
[task 2021-09-03T13:26:31.893Z] 13:26:31     INFO - TEST-UNEXPECTED-PASS | /wasm/jsapi/function/constructor.tentative.any.worker.html | fail with missing parameters - expected FAIL
[task 2021-09-03T13:26:31.893Z] 13:26:31     INFO - TEST-INFO | expected FAIL
[task 2021-09-03T13:26:31.895Z] 13:26:31     INFO - 
[task 2021-09-03T13:26:31.895Z] 13:26:31     INFO - TEST-UNEXPECTED-PASS | /wasm/jsapi/function/constructor.tentative.any.worker.html | fail with non-string parameters & results - expected FAIL
[task 2021-09-03T13:26:31.895Z] 13:26:31     INFO - TEST-INFO | expected FAIL
[task 2021-09-03T13:26:31.897Z] 13:26:31     INFO - 
[task 2021-09-03T13:26:31.897Z] 13:26:31     INFO - TEST-PASS | /wasm/jsapi/function/constructor.tentative.any.worker.html | fail with non-existent parameter and result type 
[task 2021-09-03T13:26:31.897Z] 13:26:31     INFO - TEST-UNEXPECTED-PASS | /wasm/jsapi/function/constructor.tentative.any.worker.html | fail with non-function object - expected FAIL
[task 2021-09-03T13:26:31.897Z] 13:26:31     INFO - TEST-INFO | expected FAIL

Looking into this right now, not sure what's wrong yet.

Status: NEW → RESOLVED
Closed: 3 years ago
tracking-firefox93: ? → ---
Resolution: --- → DUPLICATE

This failure persists with the patch for bug 1728985 applied. In its https://phabricator.services.mozilla.com/D124458 Ryan commented "we don't get the ClassSpec::DontDefineConstructor flag which causes this null class to be attempted to be defined on the global". Should these failures be handled in bug 1728985 or here?

Status: RESOLVED → REOPENED
tracking-firefox93: --- → ?
Flags: needinfo?(rhunt)
Resolution: DUPLICATE → ---

I think this failure is potentially unrelated bug 1728985, but I don't know the root cause yet. I saw it was marked as duplicated, so I assumed it was resolved by the patch on bug 1728985, will continue looking.

Flags: needinfo?(rhunt)

The issue is that these tests pass no matter whether WebAssembly.Function is defined or not, because they only care that an TypeError is thrown and a TypeError is thrown if WA.Function is not defined.

Some of the WPT's for WebAssembly.Function pass no matter whether
the feature is enabled or not. Ideally we should make the tests
more sophisticated, but updating the test expectations is a short
term fix.

Assignee: nobody → rhunt
Priority: -- → P1
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f2f788cc270
Ensure test fails when feature is off; r=lth
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30356 for changes under testing/web-platform/tests
Regressed by: 1715275
Has Regression Range: --- → yes

https://hg.mozilla.org/mozilla-central/rev/3f2f788cc270

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Upstream PR merged by Ms2ger
Attachment #9239479 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: