Closed Bug 1729093 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30338 - Implement AppHistoryEntry's dispose event

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox94 fixed)

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30338 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30338
Details from upstream follow.

b'Domenic Denicola <domenic@chromium.org>' wrote:

Implement AppHistoryEntry's dispose event

At least, for renderer-initiated disposals. Browser-initiated
disposals are tracked in https://crbug.com/1241598.

This also doesn't work in bfcache cases, as described in
https://crbug.com/1241655. Those are more generally broken.

Bug: 1183545
Change-Id: Ife4f022909d266d20ae04a5e543286bd60ec9107
Reviewed-on: https://chromium-review.googlesource.com/3140225
WPT-Export-Revision: 913d58485ba46ffbc1e91de152c53ed4f5babac4

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 1 subtests

Status Summary

Firefox

OK : 8
FAIL : 8

Chrome

OK : 8
PASS : 3
FAIL : 5

Safari

OK : 7
FAIL : 7
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/per-entry-events/dispose-cross-document.html
No dispose events are fired due to cross-document forward pruning: FAIL (Chrome: PASS, Safari: FAIL)
/app-history/app-history-entry/entries-after-cross-document-forward-pruning.html
appHistory.entries() behavior after forward-pruning due to cross-document navs: FAIL (Chrome: PASS)
/app-history/per-entry-events/dispose-same-document-navigate-during.html
navigate() during a same-document-navigation-initiated dispose works (since it's after the previous navigation): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/per-entry-events/dispose-same-document-reload-with-transitionWhile.html
dispose events are not fired when doing a same-document reload using appHistory.reload() and transitionWhile(): FAIL (Chrome: PASS, Safari: FAIL)
/app-history/per-entry-events/dispose-same-document-replace-with-transitionWhile.html
dispose events when doing a same-document replace using appHistory.navigate() and transitionWhile(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/per-entry-events/dispose-same-document-replaceState.html
dispose events when doing a same-document replace using history.replaceState(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/per-entry-events/dispose-same-document-transitionWhile.html
dispose events when forward-pruning same-document entries: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/per-entry-events/dispose-same-document.html
dispose events when forward-pruning same-document entries: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/059aed0feba8
[wpt PR 30338] - Implement AppHistoryEntry's dispose event, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b55e4d6f885e
[wpt PR 30338] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/059aed0feba8
https://hg.mozilla.org/mozilla-central/rev/b55e4d6f885e

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.