Move APZ's internal hit test implementation from APZCTreeManager to test code
Categories
(Core :: Panning and Zooming, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(5 files)
Since Layers was removed, APZCTreeManager::GetAPZCAtPoint() (which I've started to call APZ's "internal hit test" implementation, to contrast it with GetAPZCAtPointWR() which delegates most of the hit test work to an external component (WebRender)) is only used by tests.
In this bug, I'm going to move it out of APZCTreeManager, and into test-specific code (and subsequently possibly refactor it into a simpler form that's more purpose-suited for the tests and easier to maintain).
This is task #2 from bug 1593381 comment 2, which I'm spinning out to its own bug.
This work does not block the removal of LayerMetricsWrapper, Layer, or any other Layers-specific code outside of APZ.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D126155
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D126156
|
|
Assignee | |
Comment 4•3 years ago
|
||
This use happened during shutdown, at which time the fallback
behaviour of the WebRender hit tester (to return the root APZC)
is equally suitable.
Depends on D126157
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D126158
|
|
Assignee | |
Comment 6•3 years ago
|
||
(In reply to Botond Ballo [:botond] from comment #0)
In this bug, I'm going to move it out of APZCTreeManager, and into test-specific code (and subsequently possibly refactor it into a simpler form that's more purpose-suited for the tests and easier to maintain).
The "refactor it into a simpler form that's more purpose-suited for the tests and easier to maintain" part will be done in bug 1731700.
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e14d3e46c82d Make the 'apz.manager' log module a static member of APZCTreeManager so other classes can use it. r=hiro https://hg.mozilla.org/integration/autoland/rev/66a280d82108 Move GuidComparatorIgnoringPresShell to ScrollableLayerGuid.h. r=hiro https://hg.mozilla.org/integration/autoland/rev/2b0750f25d7b Extract an IAPZHitTester interface with WebRender and internal hit test implementations. r=hiro https://hg.mozilla.org/integration/autoland/rev/7038ae26f84c Remove the only remaining non-test use of the internal hit tester. r=hiro https://hg.mozilla.org/integration/autoland/rev/f4f653fca7d2 Move InternalHitTester into test code. r=hiro
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e14d3e46c82d
https://hg.mozilla.org/mozilla-central/rev/66a280d82108
https://hg.mozilla.org/mozilla-central/rev/2b0750f25d7b
https://hg.mozilla.org/mozilla-central/rev/7038ae26f84c
https://hg.mozilla.org/mozilla-central/rev/f4f653fca7d2
Description
•