Closed Bug 1729121 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 30345 - Improve media queries JS test

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30345 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30345
Details from upstream follow.

b'Sam Sneddon <gsnedders@apple.com>' wrote:

Improve media queries JS test

This is sorta undoing what @Emilio (and I reviewed) did in #28881, instead using lazily evaluated template literals for the tests allowing them to have constant names across environments. (The status quo, and the previous status quo, of including a number was extremely poor, as some things could change the number of tests run!)

Additionally, fix up some asserts which aren't in tests, which are currently causing this to ERROR (due to them failing) in Chrome and Safari.

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 805 subtests

Status Summary

Firefox

OK : 1
PASS: 803

Chrome

OK : 1
PASS: 586
FAIL: 217

Safari

OK : 1
PASS: 564
FAIL: 236

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4e6baabba43
[wpt PR 30345] - Improve media queries JS test, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.