SeaMonkey 32x32 default icon has light stripe at the bottom
Categories
(SeaMonkey :: Themes, enhancement)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: frg, Assigned: frg)
Details
(Whiteboard: SM2.53.10)
Attachments
(3 files, 1 obsolete file)
|
51.98 KB,
image/png
|
Details | |
|
7.15 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
600.10 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
32x32 icon has a grey bar at the bottom.
Some one in alt.comp.software.seamonkey thought that a SeaMonkey icon looks a little odd with a white dot at the bottom and yes it seems so for the 32x32 if you zoom it.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
After hours of work I present the new 32x32 fixed icon.
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: branding has a glitch
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --
|
|
Assignee | |
Comment 3•3 years ago
•
|
||
Not as noticeable but 22px and 24px also have the gray dent at the bottom.
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: even more branding grief
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): trivial++
String changes made by this patch: --
Comment on attachment 9239474 [details] [diff] [review]
1729153-fixdefault32-v1_1-25310.patch
[Triage Comment]
LGTM r/a=me
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/a2b8048ed190
Fix gray bottom stripe in SeaMonkey default icons. r=IanN
|
|
Assignee | |
Updated•3 years ago
|
Hi again.
Others and I are still seeing this issue in "SeaMonkey 32x32 icon still glitched?" newsgroup thread in alt.comp.software.seamonkey newsgroup. I see it (seamonkey.exe) in my 64-bit W10 Pro (default DPI on a 1080 monitor [1920x1080]). I don't see this issue in my old, updated Debian Jessie v8 and a borrowed macOS Big Sur v11.6.1 though. Maybe they missed an icon?
Did a Windows icon get missed?
|
|
Assignee | |
Comment 7•3 years ago
|
||
2 more evil icons were still hidden in the shadows of the source tree.
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Minor cosmetic glitch in Windows and macOS only.
Testing completed (on m-c, etc.): 2.53.11b1 pre
Risk to taking this patch (and alternatives if risky): trivial.
String changes made by this patch: --
Comment on attachment 9251760 [details] [diff] [review]
1729153-2-fixdefault32-25311.patch [checked in comment 9 target 2.93a1 2.53.11]
[Triage Comment]
r/a=me
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/a43fd00954e3 Part 2: Remove light stripe from SeaMonkey Windows and macOS 32x32 icons. r=IanN
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 10•3 years ago
|
||
Target 2.53.10
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/3a17be5fd6670299d9c2a88ba5c35814de56f77c
Fix gray bottom stripe in SeaMonkey default icons. r=IanN a=IanN
Target 2.53.10.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/e307c9705c316ca043dbd854e48387bb6076de32
Part 2: Remove light stripe from SeaMonkey Windows and macOS 32x32 icons. r=IanN a=IanN
Description
•