1729170 - Make `nsTextFragment::CharAt` should take `uint32_t` rather than `int32_t`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://searchfox.org/mozilla-central/rev/36a784a4c4b666c3da6677259a635c48a058c95a/dom/base/nsTextFragment.h#213

I know it's never larger than NS_MAX_TEXT_FRAGMENT_LENGTH, so it has no problem actually.

However, child offset in DOM nodes is uint32_t. So without explicit conversion, we get this waning in Fabricator.

WARNING: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int32_t' (aka 'int') is implementation-defined

So I think that it should take uint32_t for avoiding unnecessary casting.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1729170 - Make all methods of `nsTextFragment` take `uint32_t` for the offset and length of text r=smaug!

nsTextFragment is a storage of data node and DOM offset is uint32_t, but
some methods of nsTextFragment takes int32_t for the offset/length in
its text. Therefore, callers need to cast from uint32_t to int32_t if
the offset value is offset in a DOM node. Therefore, all methods of it should
take uint32_t values as offset/length in its text.

Depends on D127612

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05d338fecf52
Make all methods of `nsTextFragment` take `uint32_t` for the offset and length of text r=smaug

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/05d338fecf52