1729236 - Remove nsDisplayItem::GetPaintRect()

Status: RESOLVED FIXED

(Core :: Web Painting, task)

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1729236 - Don't use GetPaintRect for CreateWebRenderCommands. r?jrmuizel

WebRender prefers to know the full bounds of the primitive, since it makes invalidation easier (and doesn't increase the size of the commands we send).

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1729236 - Don't use GetPaintRect for painting text. r?jrmuizel

Text is the exception, where clipping the WR commands to the paint rect can let us reduce the size sent.
We want to avoid this when doing fallback painting, since we don't want to have to track paint rect changes for invalidation.

Depends on D124588

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1729236 - Remove GetPaintRect. r?jrmuizel

Depends on D124589

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf228d1f3b49
Don't use GetPaintRect for CreateWebRenderCommands. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0d26dce41a12
Don't use GetPaintRect for painting text. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8ebf965d624b
Remove GetPaintRect. r=jrmuizel

Comment 5

[Iulian Moraru]

Backed out for causing multiple failures.

Push with failures

Failure log for dt address sanitizer failures
Failure log for bc address sanitizer failures
Failure log for mochitest-plain address sanitizer failures
Failure log for mochitest-plain failures on test_svg_filter_animation.html
Failure log for mochitest-plain failures on test_taintedfilters.html

Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49a5aa4c8eb7
Don't use GetPaintRect for CreateWebRenderCommands. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a3021a3499e1
Don't use GetPaintRect for painting text. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/1333d00d417c
Remove GetPaintRect. r=jrmuizel

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing reftest failures in layout/reftests/svg/filters/filter-giant.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a66fb0e6365d88cec8bcff53ae2a04ae98a65b46

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e292895282a
Don't use GetPaintRect for CreateWebRenderCommands. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c6bcc4ed3d2e
Don't use GetPaintRect for painting text. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c5b71e6ce0e5
Remove GetPaintRect. r=jrmuizel

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7e292895282a
https://hg.mozilla.org/mozilla-central/rev/c6bcc4ed3d2e
https://hg.mozilla.org/mozilla-central/rev/c5b71e6ce0e5

Comment 10

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing Bug 1424348 a=backout
Backout link : https://hg.mozilla.org/mozilla-central/rev/e8e345cec68d8e71ba6f6f3c5ff2fe33605c670f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a17c98fe3971
Don't use GetPaintRect for CreateWebRenderCommands. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/973c5761459d
Don't use GetPaintRect for painting text. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/e8a29c8f1e09
Remove GetPaintRect. r=jrmuizel

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a17c98fe3971
https://hg.mozilla.org/mozilla-central/rev/973c5761459d
https://hg.mozilla.org/mozilla-central/rev/e8a29c8f1e09

Comment 13

[xcasxcursex]

Ah, it was backed out and then re-added. Maybe that explains why this bug disappeared for one day and then came back slightly changed: https://bugzilla.mozilla.org/show_bug.cgi?id=1730314 ?