Closed Bug 1729236 Opened 2 months ago Closed 1 month ago

Remove nsDisplayItem::GetPaintRect()

Categories

(Core :: Web Painting, task)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

No description provided.

WebRender prefers to know the full bounds of the primitive, since it makes invalidation easier (and doesn't increase the size of the commands we send).

Text is the exception, where clipping the WR commands to the paint rect can let us reduce the size sent.
We want to avoid this when doing fallback painting, since we don't want to have to track paint rect changes for invalidation.

Depends on D124588

Depends on D124589

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf228d1f3b49
Don't use GetPaintRect for CreateWebRenderCommands. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0d26dce41a12
Don't use GetPaintRect for painting text. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8ebf965d624b
Remove GetPaintRect. r=jrmuizel
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49a5aa4c8eb7
Don't use GetPaintRect for CreateWebRenderCommands. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a3021a3499e1
Don't use GetPaintRect for painting text. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/1333d00d417c
Remove GetPaintRect. r=jrmuizel

Backed out for causing reftest failures in layout/reftests/svg/filters/filter-giant.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a66fb0e6365d88cec8bcff53ae2a04ae98a65b46

Push with failures

Failure log

Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e292895282a
Don't use GetPaintRect for CreateWebRenderCommands. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c6bcc4ed3d2e
Don't use GetPaintRect for painting text. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c5b71e6ce0e5
Remove GetPaintRect. r=jrmuizel
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 94 Branch → ---
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a17c98fe3971
Don't use GetPaintRect for CreateWebRenderCommands. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/973c5761459d
Don't use GetPaintRect for painting text. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/e8a29c8f1e09
Remove GetPaintRect. r=jrmuizel
Status: REOPENED → RESOLVED
Closed: 1 month ago1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

Ah, it was backed out and then re-added. Maybe that explains why this bug disappeared for one day and then came back slightly changed: https://bugzilla.mozilla.org/show_bug.cgi?id=1730314 ?

Regressions: 1730344
Regressions: 1730314
Regressions: 1730682
Regressions: 1731785
Flags: needinfo?(matt.woodrow)
See Also: → 1734457
You need to log in before you can comment on or make changes to this bug.