1729241 - Refactor spatial tree accessors and update

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1729241 - Pt 1 - Refactor spatial tree accessors and update

In future, spatial tree nodes will not be stored in a flat
vec array. Instead, they'll be retained based on their unique
key. To prepare for this, refactor the spatial tree so that
all access to nodes is done via an accessor, and the tree
update no longer relies on split_mut.

Comment 2

[Glenn Watson [:gw]]

Attachment: Bug 1729241 - Pt 2 - Refactor spatial tree accessors and update

Previously, the GPU transform palette always stored the local ->
world transform for each spatial node with O(1) access time.

This won't be feasible in future when spatial nodes are retained
and stored with opaque handles.

Although this was previously a small optimization, it's no longer
important. With picture caching and raster roots, querying the
local -> world transform should be relatively rare (and even rarer
once all surfaces establish raster roots).

We still retain the optimization that querying an identity transform
(where the from == to spatial node) avoids a hash lookup and always
resolves to the first transform in the palette, since this is quite
common.

Comment 3

[Glenn Watson [:gw]]

Attachment: Bug 1729241 - Pt 3 - Make spatial node indices an opaque type

Since spatial node indices will become opaque handles in future,
remove the last part of code outside spatial_tree that relies
on the index. In this case, switch the hit-testing code to use
the spatial node indices as a hash key. This is unlikely to have
any noticeable performance impact since hit-tests are relatively
rare, and generally only access a small number of spatial nodes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a90fa338971b
Pt 1 - Refactor spatial tree accessors and update r=gfx-reviewers,kvark

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a90fa338971b

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aae10c334f6d
Pt 2 - Refactor spatial tree accessors and update r=gfx-reviewers,kvark
https://hg.mozilla.org/integration/autoland/rev/c3ddc8726b7b
Pt 3 - Make spatial node indices an opaque type r=gfx-reviewers,kvark

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/aae10c334f6d
https://hg.mozilla.org/mozilla-central/rev/c3ddc8726b7b