Closed
Bug 1729288
Opened 3 years ago
Closed 3 years ago
Optimize and simplify getSlotRange{Unchecked}
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(3 files)
getSlotRangeUnchecked is used in some hot paths. We can simplify and optimize this function and its callers.
|
Assignee | |
Comment 1•3 years ago
|
||
This code isn't hot so it's simpler to use initSlotUnchecked.
Inline this in fillInAfterSwap because it's such a special use case.
|
||
Updated•3 years ago
|
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D124622
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D124623
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/442649bb62fb part 1 - Inline initSlots in the caller and simplify it. r=jonco https://hg.mozilla.org/integration/autoland/rev/d4a02df6ae95 part 2 - Optimize slot initialization during allocation. r=jonco https://hg.mozilla.org/integration/autoland/rev/dc213fb89bb2 part 3 - Simplify getSlotRange with a lambda function. r=jonco
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/442649bb62fb
https://hg.mozilla.org/mozilla-central/rev/d4a02df6ae95
https://hg.mozilla.org/mozilla-central/rev/dc213fb89bb2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•