Closed Bug 1729295 Opened 3 years ago Closed 3 years ago

PinOnScreen doesn't work

Categories

(GeckoView :: General, defect)

Unspecified
All
defect

Tracking

(firefox94 fixed)

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

When clicking accessiblecaret then moving it, I can find the following error.

09-06 21:38:39.403  4054  4069 D GeckoViewContent[C]: handleEvent: mozcaretstatechanged
09-06 21:38:39.403  4054  4069 E Web Content: [JavaScript Error: "TypeError: can't access property "sendRequest", this.eventDispatcher is undefined" {file: "resource:///actors/GeckoViewContentChild.jsm" line: 291}]
09-06 21:38:39.403  4054  4069 E Web Content: handleEvent@resource:///actors/GeckoViewContentChild.jsm:291:11

This seems to misss super.actorCreated() call. in GeckoViewContentChild.actorCreated

When tapping accessiblecaret and moving/releasing it, the follow error occurs.

GeckoViewContent[C]: handleEvent: mozcaretstatechanged
Web Content: [JavaScript Error: "TypeError: can't access property "sendRequest", this.eventDispatcher is undefined" {file: "resource:///actors/GeckoViewContentChild.jsm" line: 291}]
Web Content: handleEvent@resource:///actors/GeckoViewContentChild.jsm:291:11

I think that we miss super.actorCreated() call in actorCreate(). This might be
regression by bug 1661480.

Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/a4d2ca53b2a4
Call super.actorCreated() to use eventDispatcher. r=geckoview-reviewers,agi
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: