172930 - issues loading userChrome.css and other css files via file:

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Jeremy M. Dolan]

mozilla is no longer using userChrome.css in profiles, nor is it loading CSS via
file:

When loading an XHTML page with this line, the CSS is applied in 2002100208. In
todays build, no css is applied.

<link rel="stylesheet" type="text/css" href="generic.css" media="screen"
title="clean" />

Cc'ing walk as timeless says he mentioned something about this in IRC earlier today.

Comment 1

[Darin Fisher]

-> me ... someone is incorrectly generating a nsIURI by instantiating a
nsStandardURL and then expecting the file protocol handler to load it!  gotta
track down and fix whomever is creating that nsIURI.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm... So I just looked and all of nsChromeRegistry (this loads user*.css),
nsStyleLinkElement (handles loads of <link>, eg), and nsCSSParser (handles
@import rules in CSS) are using NS_NewURI to create the nsIURI object from the
string...

Comment 3

[Darin Fisher]

nevermind, the real problem is that nsStandardURL::Clone doesn't "clone"
mSupportsFileURL :-(  ... easy enough to fix.

Comment 4

[Darin Fisher]

here's the patch that i just checked in:

Index: nsStandardURL.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/base/src/nsStandardURL.cpp,v
retrieving revision 1.37
diff -u -r1.37 nsStandardURL.cpp
--- nsStandardURL.cpp	6 Oct 2002 02:20:27 -0000	1.37
+++ nsStandardURL.cpp	6 Oct 2002 19:30:08 -0000
@@ -1486,6 +1486,7 @@
     clone->mFile = mFile;
     clone->mHostA = mHostA ? nsCRT::strdup(mHostA) : nsnull;
     clone->mMutable = PR_TRUE;
+    clone->mSupportsFileURL = mSupportsFileURL;
     clone->mHostEncoding = mHostEncoding;
     clone->mSpecEncoding = mSpecEncoding;
 

marking FIXED

Comment 5

[Boris Zbarsky [:bzbarsky]]

sr=me for that patch, a little posthumously.  ;)

Comment 6

[Jeremy M. Dolan]

v, userChrome and web pages with css via file: