Closed Bug 1729329 Opened 5 months ago Closed 3 months ago

Remove obsolete OOM handling from XSLT code

Categories

(Core :: XSLT, task)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: peterv, Assigned: peterv, NeedInfo)

Details

Attachments

(23 files, 1 obsolete file)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

Depends on D124675

Attachment #9239684 - Attachment description: Bug 1729329 - Mark txExecutionState::addInstruction as infallible. r?farre! → Bug 1729329 - Make txExecutionState::addInstruction return the added instruction. r?farre!
Attachment #9239682 - Attachment is obsolete: true
Attachment #9239683 - Attachment description: Bug 1729329 - Mark txExecutionState::addToplevelItem as infallible. r?farre! → Bug 1729329 - Minor cleanup related to txExecutionState::addToplevelItem. r?farre!
Pushed by pvanderbeken@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e88066fc3cff
Remove simple OOM checking. r=farre
https://hg.mozilla.org/integration/autoland/rev/e8cb19427b66
Remove OOM checks after calling infallible nsTArray methods. r=farre
https://hg.mozilla.org/integration/autoland/rev/6fba0c67d51e
Mark txPushNewContext::addSort as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/7c2ea3b9ab2b
Mark FunctionCall::addParam as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/b1ed3b891384
Mark PredicateList::add as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/122ca4b1e1d5
Mark PathExpr::addExpr as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/105de5963c64
Mark UnionExpr::addExpr as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/1f89052caba5
Mark txUnionNodeTest::addNodeTest as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/ea3b6cfc339c
Mark txStack::push as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/9c171b04d134
Mark txExecutionState::pushEvalContext as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/9008da35b3bb
Mark txExecutionState::pushBool as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/cebb8e6014d9
Mark txExecutionState::pushResultHandler as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/db670850cf51
Mark txStylesheetCompilerState::pushPtr as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/73767c02ff30
Mark txStylesheetCompilerState::pushHandlerTable as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/e54965a98dc1
Mark txStylesheetCompilerState::pushSorter as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/28ec9a8c87d8
Mark txStylesheetCompilerState::pushObject as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/41bb3539816d
Mark txStylesheetCompilerState::pushChooseGotoList as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/b2569472c3ff
Mark txList::insertBefore as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/75a787792d04
Minor cleanup related to txExecutionState::addToplevelItem. r=farre
https://hg.mozilla.org/integration/autoland/rev/95961bdd8342
Make txExecutionState::addInstruction return the added instruction. r=farre
https://hg.mozilla.org/integration/autoland/rev/71b980477982
Remove impossible to hit OOM errors from XSLT code. r=farre
https://hg.mozilla.org/integration/autoland/rev/dc99904cbba2
Convert nsCOMArrays in XSLT code to nsTArrays and remove impossible to hit OOM errors. r=farre
https://hg.mozilla.org/integration/autoland/rev/a93125ed5957
Make mInScopeVariables hold objects instead of pointers. r=farre

Backed out for causing mochitest failures and also xpcshell and web-platform-test.

Flags: needinfo?(peterv)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:peterv, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(peterv)
Flags: needinfo?(afarre)
Pushed by pvanderbeken@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a9c3464e037
Remove simple OOM checking. r=farre
https://hg.mozilla.org/integration/autoland/rev/d93e66bc2154
Remove OOM checks after calling infallible nsTArray methods. r=farre
https://hg.mozilla.org/integration/autoland/rev/6e1b0fc0ee6c
Mark txPushNewContext::addSort as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/6eb3462d63e9
Mark FunctionCall::addParam as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/47f04e3c33c0
Mark PredicateList::add as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/e34f9ae476c1
Mark PathExpr::addExpr as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/fdfd70796ab4
Mark UnionExpr::addExpr as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/bb1250797dca
Mark txUnionNodeTest::addNodeTest as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/c8c6cfab5723
Mark txStack::push as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/e4193ee11130
Mark txExecutionState::pushEvalContext as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/07314018102a
Mark txExecutionState::pushBool as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/1c79314ea7c5
Mark txExecutionState::pushResultHandler as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/8d9a516fb524
Mark txStylesheetCompilerState::pushPtr as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/024b09e81b35
Mark txStylesheetCompilerState::pushHandlerTable as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/d38eba8ca141
Mark txStylesheetCompilerState::pushSorter as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/3357e8018271
Mark txStylesheetCompilerState::pushObject as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/a0671003efc4
Mark txStylesheetCompilerState::pushChooseGotoList as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/e7402b2c3f27
Mark txList::insertBefore as infallible. r=farre
https://hg.mozilla.org/integration/autoland/rev/75a3619fb410
Minor cleanup related to txExecutionState::addToplevelItem. r=farre
https://hg.mozilla.org/integration/autoland/rev/e1f1f70c4880
Make txExecutionState::addInstruction return the added instruction. r=farre
https://hg.mozilla.org/integration/autoland/rev/a5b8c15d4967
Remove impossible to hit OOM errors from XSLT code. r=farre
https://hg.mozilla.org/integration/autoland/rev/e949f56ee10c
Convert nsCOMArrays in XSLT code to nsTArrays and remove impossible to hit OOM errors. r=farre
https://hg.mozilla.org/integration/autoland/rev/d9a45ee48672
Make mInScopeVariables hold objects instead of pointers. r=farre
Flags: needinfo?(peterv)
You need to log in before you can comment on or make changes to this bug.