Open Bug 1729345 Opened 4 years ago Updated 4 years ago

[Accessibility - minor] Save to Pocket tag Save button is not disabled when tag is created with Enter press - FIrefox MacOS

Categories

(Firefox :: Pocket, enhancement)

Product:
Firefox
Component:
Pocket
Version:
Firefox 92
Type:
enhancement

Tracking

()

People

(Reporter: luke.williams, Unassigned, NeedInfo)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

MacOS Firefox 92.0b7 (64-bit):

  1. Save an article to Pocket
  2. Add a tag and hit Enter (NOT click "save" with mouse)

Actual results:

Saving the article is quick enough (<1s) but tagging by hitting Enter is extremely slow. Sometimes it resolves in 10-30s, but sometimes it goes 60s+ and I just close the page. (On rare occasions it resolves in ~2s.)

Expected results:

Tagging should be fast (<1s for sure).

Tagging completes quickly when the tagging Save button is clicked with the mouse. It is only with Enter that tagging is slow.

Tagging is also quick on iOS Firefox with the Pocket Plug-in. As mentioned, Saving in MacOS Firefox is also fast; it's only the tagging that for some reason takes a very long time to indicate completion.

Notes:

  • It appears the tag is always added quickly (I can verify at getpocket.com), so the issue is on the response, not on the POST to Pocket. If I close the page after 2 seconds of the Saving Tag dialog showing, the tag is consistently added, but Firefox doesn't show a Success dialog.
  • There is another difference between Enter key press and Save button press to save a tag, which is at least a small bug and seems potentially related. Clicking Save will disable the Save button, but pressing Enter will not disable the Save button. There must be some separate code path for Enter press that causes different behavior and a much greater delay.

Related bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1720567 ("Pocket tag can no longer be added with keyboard")

Thanks!

Update: the larger issue here (tag save speed with "Enter") appears fixed in 92.0b9 (64-bit). Tag saving is fast again.

Only the minor side issue persists: the Save button not being disabled when Enter is pressed. Updated title accordingly.

Summary: [Accessibility] Pocket tagging is extremely slow when pressing Enter to save (not clicking button with mouse) - FIrefox MacOS → [Accessibility - minor] Save to Pocket tag Save button is not disabled when tag is created with Enter press - FIrefox MacOS

The Bugbug bot thinks this bug should belong to the 'Firefox::Pocket' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Pocket

Tested on Nightly 93.0a1 across platforms: the Save button is disabled and quickly reenabled just before "Tags added" panel is displayed, so it's barely visible.
Confirmed as Enhancement.

Severity: -- → S4
Status: UNCONFIRMED → NEW
Type: defect → enhancement
Ever confirmed: true

Might also be related bug 1729847

Seems something's up with enter and tagging. Some cases it's just closing the panel, others it's being very slow.

Might be related to bug 1693582 which recently landed in nightly.

It's not an issue created by bug 1693582, testing before bug 1693582 shows the Save button is disabled and quickly reenabled still. My guess is this has been the case for a while, but still a bug.

Feel free to update this if you see the initial issue of it being slow again, or other questions or updates.

Flags: needinfo?(sdowne)
You need to log in before you can comment on or make changes to this bug.