Do not key rule tree children by cascade level.
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 obsolete file)
|
Assignee | |
Comment 1•3 years ago
|
||
This was needed before, since we used to optimize empty style rules away
(and thus we could get confused between the important and non-important
block for two different elements).
But now we always keep them, and thus there's no way for the same
declaration block to appear in two similar paths of the rule tree
without different cascade levels.
I found this because if we want to implement the revert-layer CSS-wide
keyword, we need to put the layer order in the rule tree. However the
same thing applies: The same style source will always have the same
layer for a given cascade-data rebuild, so I believe this should be
fine.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c5f2e282204 Do not key rule tree children by cascade level. r=jwatt
|
||
Comment 3•3 years ago
|
||
Backed out for bc failures
Backout link : https://hg.mozilla.org/integration/autoland/rev/4e222f2e8236ab2d953306c136b3ae6197066315
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-browser-chrome-swr-e10s%2Cbc2&revision=4c5f2e282204a1407c89dc6110760a7bd9c901bd&selectedTaskRun=I5hNv0VcQQq5yTvoelzYCA.0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=351490217&repo=autoland&lineNumber=4568
|
|
Assignee | |
Comment 4•3 years ago
|
||
Aye, I hadn't considered the same rule matching the same element in two different scopes... So I think the patch was wrong after all.
|
||
Updated•3 years ago
|
Description
•