1729428 - The remote profiler doesn't pick up the preferences from the remote about:profiling page

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Julien Wajsberg [:julienw]]

STR:

1. Open about:debugging
2. Connect to a phone or another firefox that's run with --start-debugger-server
3. Switch to the "custom" preset and click on "Edit Settings"
4. Change some settings, then click on the back button in the page

=> Notice that nothing changed in the devtools panel (look especially at the description below). If you changed the preset in the settings page, it's still in "custom" in the devtools panel.

5. Select some preset, then come back to "custom" and click on "Edit Settings"

=> Notice that nothing changed in the settings page, but the custom values should have been reset.

This is due to how we handle preferences now, and exposes a bug that was present but not visible.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

The regressed by field suggests this broke yesterday. Can you please clarify what broke this if 92/93 are also affected?

Comment 2

[Julien Wajsberg [:julienw]]

Yeah this broke yesterday, this was working before as far as I could see!

Comment 3

[Julien Wajsberg [:julienw]]

try is: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd847066a14edc76e5584735837cbce5f5c366f2

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: Bug 1729428 - [devtools performance] Use a different page context for the remote devtools panel r=jdescottes!

Comment 5

[Julien Wajsberg [:julienw]]

Attachment: Bug 1729428 - [devtools performance] Properly destroy all observers in all cases r=jdescottes!

Depends on D124970

Comment 6

[Julien Wajsberg [:julienw]]

Attachment: Bug 1729428 - [devtools performance] Split helpers from head.js so that they can be reused more easily r=jdescottes!

Depends on D124971

Comment 7

[Julien Wajsberg [:julienw]]

Attachment: Bug 1729428 - [devtools performance] In tests, load the real profiler UI in about:debugging instead of a blank page r=jdescottes!

Depends on D124972

Comment 8

[Julien Wajsberg [:julienw]]

Attachment: Bug 1729428 - [devtools performance] Add a test to check that settings are properly applied when profiling in about:debugging r=jdescottes!

Depends on D124973

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67bdb0022b4b
[devtools performance] Use a different page context for the remote devtools panel r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/8b8092a4b068
[devtools performance] Properly destroy all observers in all cases r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/2086475d4f84
[devtools performance] Split helpers from head.js so that they can be reused more easily r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/cfb44eceecab
[devtools performance] In tests, load the real profiler UI in about:debugging instead of a blank page r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/ae13bde882aa
[devtools performance] Add a test to check that settings are properly applied when profiling in about:debugging r=jdescottes

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/67bdb0022b4b
https://hg.mozilla.org/mozilla-central/rev/8b8092a4b068
https://hg.mozilla.org/mozilla-central/rev/2086475d4f84
https://hg.mozilla.org/mozilla-central/rev/cfb44eceecab
https://hg.mozilla.org/mozilla-central/rev/ae13bde882aa