1729445 - Don't batch texture uploads for items that are as large as the staging texture size

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Nicolas Silva [:nical]]

In other words, don't put items in a staging texture if we don't expect to be able to fit other items and get some batching out of it.

The batched upload path has an extra cost on Windows: We do an extra copy of the item. That cost is easily recovered if we can batch many uploads into a single staging texture which typically works very well for glyphs but for some larger items it can be slower than regular upload.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1729445 - Don't batch texture uploads for large-ish items. r=jnicol

In other words, don't batch items if we don't expect to be able to fit other items in the staging texture. The batched upload path has a cost on Windows (an extra copy) that is easily recovered when batching a lot of small items (typically works very well with glyphs), but we get diminishing returns and even slowdowns for larger items.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddea60ea119b
Don't batch texture uploads for large-ish items. r=jnicol

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ddea60ea119b