1729467 - When failing pixel comparison test_eme_canvas_blocked.html spams logs

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

When test_eme_canvas_blocked.html fails due to pixel comparison it results in log spam. This makes parsing logs and handling these failures more painful than it needs to be. See bug 1728927 for an example of this.

Instead of failing for each pixel, let's just break after the first failure. Any non-0 pixel indicates failure, we don't need a failure log for each of them

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1729467 - Don't log for every failing pixel in test. r?jolin

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1729467 - Restyle test to conform to code style. r?jolin

Drive by restyle of the test. Change should not impact functionality.

Depends on D124802

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a8ffeec7603
Don't log for every failing pixel in test. r=jolin
https://hg.mozilla.org/integration/autoland/rev/287831701e2d
Restyle test to conform to code style. r=jolin

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3a8ffeec7603
https://hg.mozilla.org/mozilla-central/rev/287831701e2d