1729500 - Stack traces are no longer recorded by the memory panel across reloads

Status: VERIFIED FIXED

(DevTools :: Memory, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

STR:

• open a page
• open memory panel
• Turn on "record stack stacks" via the checkbox
• reload the page
• take a memory snapshot
• Select View: Aggregate and Group by: Call Stack

ER: See some objects with call stacks

AR: We get the No call stacks found. Record call stacks before taking a snapshot. warning and none of the objects are with any stack.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1729500 - [devtools] Fix stack recording in the memory panel.

Without this, server side target were breaking stack record in the memory panel.
We have to ensure toggling stack record ON before the page starts loading.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1729500 - [devtools] Implement TargetConfigurationCommands.supports

To help know if a given configuration is supported by the backend.

Comment 3

[Release mgmt bot [:marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 4

[Release mgmt bot [:marco/ :calixte]]

Set release status flags based on info from the regressing bug 1702715

Comment 5

[Julien Wajsberg [:julienw]]

Changing severity to S2 because this is a severe impact. Thanks Alex for working on this!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af5fbdc901eb
[devtools] Implement TargetConfigurationCommands.supports r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/2a0d5c83f586
[devtools] Fix stack recording in the memory panel. r=jdescottes

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1729500 - [devtools] Change backward compat comment to 93 for recordAllocations.

If we end up uplifting these fixes, we should tweak the backward compat comments.

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/af5fbdc901eb
https://hg.mozilla.org/mozilla-central/rev/2a0d5c83f586

Comment 9

[Release mgmt bot [:marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ochameau, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Alexandre Poirot [:ochameau]]

Comment on attachment 9239888 [details]
Bug 1729500 - [devtools] Fix stack recording in the memory panel.

Beta/Release Uplift Approval Request

• User impact if declined: The memory panel would no longer record stack traces when doing a page reload.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: * open a page
• open memory panel
• Turn on "record stack stacks" via the checkbox
• reload the page
• take a memory snapshot
• Select View: Aggregate and Group by: Call Stack

ER: See some objects with call stacks

AR: We get the No call stacks found. Record call stacks before taking a snapshot. warning and none of the objects are with any stack.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mostly changes the memory panel itself. The changes outside of the memory panel are quite simple.
• String changes made/needed: no

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9239888 [details]
Bug 1729500 - [devtools] Fix stack recording in the memory panel.

P1/S2, low risk + tests, we are still in betas, uplift approved for 93 beta 8, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d4012b0b61d
https://hg.mozilla.org/releases/mozilla-beta/rev/60dd501a9eab
https://hg.mozilla.org/releases/mozilla-beta/rev/f490bf73653f

Comment 13

[Alexandru Trif, QA [:atrif]]

Reproduced with Firefox 94.0a1 (20210907214756) on Windows 10x64.
Verified fixed with Firefox 93.0b8 (20210921185902) and 94.0a1 (20210922094736) on Windows 10x64, macOS 10.15 and Ubuntu 21.04 by following the STR from comment 10.