1729561 - Test process crash ignored in gv-junit

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Looks like every single gv-junit run in CI crashes around WebExtensionTest#cancelInstall and all subsequent tests are ignored. The run is reported as successful.

[task 2021-09-07T19:41:10.268Z] 19:41:10     INFO -  TEST-PASS | org.mozilla.geckoview.test.WebExtensionTest#cancelInstall | took 133ms
[task 2021-09-07T19:41:10.268Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=796
[task 2021-09-07T19:41:10.268Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2021-09-07T19:41:10.268Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2021-09-07T19:41:10.268Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=testBrowserTabsCreateWithCookieStoreId
[task 2021-09-07T19:41:10.268Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.WebExtensionTest
[task 2021-09-07T19:41:10.268Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=742
[task 2021-09-07T19:41:10.268Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: 1
[task 2021-09-07T19:41:10.269Z] 19:41:10     INFO -  TEST-START | org.mozilla.geckoview.test.WebExtensionTest#testBrowserTabsCreateWithCookieStoreId
[task 2021-09-07T19:41:10.616Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_RESULT: shortMsg=Process crashed.
[task 2021-09-07T19:41:10.616Z] 19:41:10     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_CODE: 0
[task 2021-09-07T19:41:10.630Z] 19:41:10     INFO -  org.mozilla.geckoview.test | adb_returncode=0
[task 2021-09-07T19:41:10.632Z] 19:41:10     INFO -  Passed: 667

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Example: https://treeherder.mozilla.org/logviewer?job_id=350827553&repo=autoland&lineNumber=14675-14685

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Looks like the test harness code is crashing:

08-31 21:44:54.329  3459  3476 E AndroidRuntime: FATAL EXCEPTION: AsyncServer
08-31 21:44:54.329  3459  3476 E AndroidRuntime: Process: org.mozilla.geckoview.test, PID: 3459
08-31 21:44:54.329  3459  3476 E AndroidRuntime: java.lang.AssertionError
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.http.server.AsyncHttpServerResponseImpl.write(AsyncHttpServerResponseImpl.java:56)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at org.mozilla.geckoview.test.util.TestServer._init_$lambda-12(TestServer.kt:148)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at org.mozilla.geckoview.test.util.TestServer.lambda$vfaYmH_8PnL68opAU927gFtT6GY(TestServer.kt)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at org.mozilla.geckoview.test.util.-$$Lambda$TestServer$vfaYmH_8PnL68opAU927gFtT6GY.onRequest(lambda)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.http.server.AsyncHttpServer.onRequest(AsyncHttpServer.java:62)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.http.server.AsyncHttpServer$1$1.onHeadersReceived(AsyncHttpServer.java:159)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.http.server.AsyncHttpServerRequestImpl$2.onStringAvailable(AsyncHttpServerRequestImpl.java:75)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.LineEmitter.onDataAvailable(LineEmitter.java:45)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.Util.emitAllData(Util.java:23)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.AsyncNetworkSocket.onReadable(AsyncNetworkSocket.java:152)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.AsyncServer.runLoop(AsyncServer.java:821)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.AsyncServer.run(AsyncServer.java:658)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.AsyncServer.access$800(AsyncServer.java:44)
08-31 21:44:54.329  3459  3476 E AndroidRuntime: 	at com.koushikdutta.async.AsyncServer$14.run(AsyncServer.java:600)
08-31 21:44:54.330  3459  3476 I Process : Sending signal. PID: 3459 SIG: 9

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

We might be hitting this: https://github.com/koush/AndroidAsync/issues/685

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1729561 - Report error if not all junit tests run.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1729561 - Update com.koushikdutta.async to 3.1.0.

This fixes a crash in our test harness, see
https://github.com/koush/AndroidAsync/issues/685.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa578b55073c
Report error if not all junit tests run. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/0e17f798238c
Update com.koushikdutta.async to 3.1.0. r=owlish

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/aa578b55073c
https://hg.mozilla.org/mozilla-central/rev/0e17f798238c