Closed Bug 1729569 Opened 10 months ago Closed 10 months ago

Add a Nimbus variable for the Firefox Suggest scenario

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
94 Branch
Iteration:
94.1 - Sep 6 - Sept 19
Tracking Status
firefox92 --- fixed
firefox93 --- fixed
firefox94 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(2 files)

We could use the quickSuggestShouldShowOnboardingDialog variable to
distinguish between offline and online on the client, since offline won't get
the onboarding but online will. However, using a separate variable would be
clearer and possibly less confusing, and it would also allow us to have finer
control over the onboarding prompt if we need it.

We'll need to distinguish between teh two scenarios on the client for telemetry
pings and possible tweaks to the preferences UI.

This adds a quickSuggestScenario Nimbus variable.

We could use the quickSuggestShouldShowOnboardingDialog variable to
distinguish between offline and online on the client, since offline won't get
the onboarding but online will. However, using a separate variable would be
clearer and possibly less confusing, and it would also allow us to have finer
control over the onboarding prompt if we need it.

We'll need to distinguish between teh two scenarios on the client for telemetry
pings and possible tweaks to the preferences UI.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14505a265fdf
Add a Nimbus variable for the Firefox Suggest scenario. r=nanj
Iteration: --- → 94.1 - Sep 6 - Sept 19
Points: --- → 2
Flags: qe-verify-
Flags: in-testsuite+
Blocks: 1729587
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

[Tracking Requested - why for this release]: This is required for the Firefox Suggest rollout on a 92 dot release.

Approval Request Comment
[Feature/Bug causing the regression]: Firefox Suggest offline/online rollouts
[User impact if declined]: Needed for important rollouts on 93 and 92
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No -- this is a low-level non-visual change that doesn't require QA verification
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: See uplift coordination spreadsheet
[Is the change risky?]: Low risk relative to other uplifts needed in the patch stack
[Why is the change risky/not risky?]: This particular patch adds a hidden pref and a Nimbus variable, comes with test
[String changes made/needed]:

Attachment #9240391 - Flags: approval-mozilla-beta?

Comment on attachment 9240391 [details] [diff] [review]
93/mozilla-beta & 92/mozilla-release patch

Needed for experiments targeting Fx92. Approved for 93.0b3.

Attachment #9240391 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Moving tracking the metabugs for this work.

Comment on attachment 9240391 [details] [diff] [review]
93/mozilla-beta & 92/mozilla-release patch

Beta/Release Uplift Approval Request

  • User impact if declined: Needed for important rollouts on 93 and 92
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This particular patch adds a hidden pref and a Nimbus variable, comes with test
  • String changes made/needed:
Attachment #9240391 - Attachment description: 93 patch → 93/mozilla-beta & 92/mozilla-release patch
Attachment #9240391 - Flags: approval-mozilla-release?

Comment on attachment 9240391 [details] [diff] [review]
93/mozilla-beta & 92/mozilla-release patch

Approved for 92.0.1.

Attachment #9240391 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.