1729591 - 92-specific fixes for Firefox Suggest offline/online

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Bug 1725289 needs to be uplifted to 92 because other patches needing uplift depend on it. However, that bug added a "Firefox Suggest" string and enabled the Firefox Suggest group label/heading for all locales, but we want to keep that feature (the history scenario) restricted to en-* locales in 92, as it currently is. So we'll either need to modify the patch to bug 1725289 before uplift, or better IMO is to land a small follow-up on 92 only that restricts to en-*. I've asked flod if that will be a problem.

Comment 1

[Drew Willcoxon :adw]

This should be verified on 92.

flod says we shouldn't leave the new string exposed in the ftl on 92, so the patch here will need to remove it on 92 in addition to restricting the feature to en-* locales.

Comment 2

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: This is required for the Firefox Suggest rollout on a 92 dot release.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1729591 - 92-specific fixes for Firefox Suggest offline/online.

NOTE: This patch should land only and directly on 92, not on 93 or 94.

Bug 1725289 D122550 localized the Firefox Suggest group labels. We need that bug
as part of the patch stack we're uplifting to 92 for Firefox Suggest rollouts,
not because we want the labels to be localized (we don't), but only because
patches in the stack depend on it. On 92, the group label feature should remain
en-* only. (The group label feature is referred to as the Firefox Suggest
"history" scenario.)

This revision does the following:

• Hides the strings that were exposed in that bug by moving them to the preview
  Fluent file (note that the preview Fluent file is not yet on 92, but the
  revision that added it (bug 1709511 D123032) is also in the patch stack)
• Adds back the en-* locale check for group labels
• Restores a couple of test tasks related to locales

This revision should land on 92 after bug 1725289 D122550, obviously.

Depends on D125031

Comment 4

[Ryan VanderMeulen [:RyanVM]]

We're tracking the metabug for this work.

Comment 5

[Drew Willcoxon :adw]

Let's make this a bug about all 92-specific changes. We use an enum type in the Nimbus feature manifest (just added it actually), but enums were added in 93 (bug 1716985). Hopefully that's just a one-line change to fix, just remove the enum.

Instead of creating yet another bug/patch to uplift, let's just do it here.

Comment 6

[Drew Willcoxon :adw]

STR for QA

The only thing that needs verifying here is that the "Firefox Suggest" group label should appear on 92 for en locales, and it should not appear on 92 for non-en locales. The verification here is the same as the verification for 92 in bug 1725289 (see bug 1725289 comment 15).

This patch is landing only on 92, so this bug does not need verification on 93 or 94.

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 9240219 [details]
Bug 1729591 - 92-specific fixes for Firefox Suggest offline/online.

Beta/Release Uplift Approval Request

• User impact if declined: Needed for important rollouts on 93 and 92
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 6
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just un-exposes some l10n strings plus some minor fixes. No visible changes.
• String changes made/needed:

Comment 8

[Drew Willcoxon :adw]

Try push with everything so far: https://treeherder.mozilla.org/#/jobs?repo=try&revision=115c700bc39d33815156c15cd62c3d169dce6297

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9240219 [details]
Bug 1729591 - 92-specific fixes for Firefox Suggest offline/online.

Approved for 92.0.1.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/0531f02f1262

Comment 11

[Carmen Fat [:cfat] - Ecosystem QA]

• I have verified this issue using the Candidate 92.0.1 build (Build ID: 20210920202613) on Windows 10 x64, macOS 10.15.7 and Linux Mint 20 x64.

• Since the 92.0.1 Candidate is an en-US build, I verified this issue by changing the language in the "about:preferences" panel (please note that we are not able to verify this issue on non-en builds given we only have the en-US Candidate linked above).

• After setting the language, I verified that the "Firefox Suggest" group label is no longer displayed when typing history/bookmarks keywords in the Address Bar.

• The languages I verified are Romanian, French, German, and Polish.

Comment 12

[Drew Willcoxon :adw]

Verified per comment 11