Closed Bug 1729594 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 30390 - Make web bundle and the inner subresource requests skip Service Worker

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox94 fixed)

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30390 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30390
Details from upstream follow.

b'Tsuyoshi Horo <horo@chromium.org>' wrote:

Make web bundle and the inner subresource requests skip Service Worker

The explainer of "Subresource loading with Web Bundles" [*] doesn't
address the expected behavior of the service worker fetch interception.
And in the current implementation, if the service worker of the page
intercepts the web bundle request, the subsequent subresource requests
can’t be served from the web bundle.

As a short term solution, this CL sets the SkipServiceWorker flag of
the both requests. So the inner subresource can be served from the web
bundle.

As a long term solution, we need to figure out the ideal design of the
service worker integration. And we need to introduce an option argument
{skip_service_worker: false (default is true)} in future.

But as of now, we don’t have any good use case of the service worker
integration. So I think it is OK to land this short term solution.

[*] https://github.com/WICG/webpackage/blame/main/explainers/subresource-loading.md

Bug: 1240424
Change-Id: I230daf58da72ecfa83b1756616a8a0697144acac

Reviewed-on: https://chromium-review.googlesource.com/3145076
WPT-Export-Revision: 562ae6f0a8412c62a5fa56c16f9fed0f8c81713f

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

TIMEOUT: 2

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-bundle/subresource-loading/subresource-loading-webbundle-with-service-worker.https.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: TIMEOUT, Safari: OK)
Both Web Bundle request and Subresource fetch requests inside the Web Bundle should skip the service worker.: FAIL (Chrome: TIMEOUT, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/web-bundle/subresource-loading/subresource-loading-webbundle-with-service-worker.https.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: TIMEOUT, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c730890d8e0
[wpt PR 30390] - Make web bundle and the inner subresource requests skip Service Worker, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.