remove ScrollMetadata::mScrollClip
Categories
(Core :: Panning and Zooming, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(2 files)
After bug 1729604 there is only one user in one gtest. I haven't tried to understand the test at all but presumably since the api is unused in non-testcode we don't need to test it anymore so the test can either be removed or modified to test what it wants without using this field.
Not sure if bug 1593381 comes into play or not.
|
Assignee | |
Comment 1•3 years ago
|
||
Looks like bug 1593381 doesn't touch this call site, but the follow up bug 1729118 might.
|
||
Comment 2•3 years ago
|
||
I had a look at this, and it looks like, while HitTestingRespectsScrollClip_Bug1257288 does call SetScrollClip(), no one actually uses the scroll clip that's set, not even in test code.
So, this function can be removed without impacting the test.
One could argue that without the scroll clip, the test no longer serves its original purpose. That's fine though -- in bug 1730606, I'm going to port this test to mochitest, and I'll use the HTML testcase from the original bug (bug 1257288) as the basis for it. I don't think we need to block the removal on that.
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D125473
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81da9afea6c6 Remove unused ScrollMetadata::mScrollClip. r=botond https://hg.mozilla.org/integration/autoland/rev/8c9e9d61fc32 Remove unused LayerClip, Layer::Get/SetScrolledClip, Layer::*AncestorMaskLayer* and related code. r=botond
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/81da9afea6c6
https://hg.mozilla.org/mozilla-central/rev/8c9e9d61fc32
Description
•