Remove beta label from Show Tabbing Order widget
Categories
(DevTools :: Accessibility Tools, task, P3)
Tracking
(firefox94 fixed)
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(2 files)
We still show a "beta" label in the accessibility panel for the "show tabbing order" widget. It doesn't really provide much value at this point, especially considering it's enabled on all channels and we should remove it.
We should remove the following span:
https://searchfox.org/mozilla-central/rev/a166f59fba89fc70ebfab287f4edb8e05ed4f6da/devtools/client/accessibility/components/Toolbar.js#47-54
We should also remove the describedby prop passed to DisplayTabbingOrder
: https://searchfox.org/mozilla-central/rev/a166f59fba89fc70ebfab287f4edb8e05ed4f6da/devtools/client/accessibility/components/Toolbar.js#55
Then remove the prop in the corresponding component: https://searchfox.org/mozilla-central/rev/a166f59fba89fc70ebfab287f4edb8e05ed4f6da/devtools/client/accessibility/components/DisplayTabbingOrder.js#24,63
Finally, delete the the "beta" localized string: https://searchfox.org/mozilla-central/rev/a166f59fba89fc70ebfab287f4edb8e05ed4f6da/devtools/client/locales/en-US/accessibility.properties#245-247
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D124804
Updated•3 years ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fc1de7fea49 [devtools] Remove beta label from Show Tabbing Order widget r=nchevobbe
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D124889
Pushed by ctuns@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5330e923fa76 [devtools] Remove beta label - fix lint failures r=fix. CLOSED TREE
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2fc1de7fea49
https://hg.mozilla.org/mozilla-central/rev/5330e923fa76
Description
•