1729632 - Temporary file during mail transfers are sometimes not in the correct extensions

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[adrien.rybarczyk]

Attachment: attachment.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

Forward an email with an attachment of a non-classic extension type (Do not use pdf, xls, txt, png, ...).

Actual results:

The temporary file has the txt extension.

Expected results:

The temporary file keeps the same extension as the base file.

Comment 1

[Wayne Mery (:wsmwk)]

duplicate?

Comment 2

[Magnus Melin [:mkmelin]]

Probably.
I assume for this case .lst is mapped in the os as being text, and then at some point in the process it uses the standard suffix for the type.

Comment 3

[Alfred Peters [:infofrommozilla]]

I see it from tb78.7.1 to TB Trunk.

(In reply to Magnus Melin [:mkmelin] from comment #2)

Probably.
I assume for this case .lst is mapped in the os as being text, and then at some point in the process it uses the standard suffix for the type.

Yes, I think that is what is being done here:

https://searchfox.org/comm-central/source/mailnews/mime/src/mimedrft.cpp#1818
| // Let's build a temp file with an extension based on the content-type:
| // nsmail.<extension>

https://searchfox.org/comm-central/rev/0f03d5e0469635ae6c2dd85f28b751b813ddf703/mailnews/mime/src/mimedrft.cpp#1834
| rv = mimeFinder->GetPrimaryExtension(contentType, EmptyCString(),
| fileExtension);

Comment 4

[Alfred Peters [:infofrommozilla]]

(In reply to Wayne Mery (:wsmwk) from comment #1)

duplicate?

Bug 823233

'.lst' or '.log' files become nsmail.txt
'*.7z' becomes nsmail.tmp

And Bug 1713213 then has for sure the same cause.

Comment 5

[Wayne Mery (:wsmwk)]

Calum, do you agree with comment 4? If so, can you close these as dups?

Comment 6

[Calum Mackay]

I'm not sure about duplicates; I can't reproduce Bug 823233 (Daily 0917; MacOS 10.15.7); but then the submitter notes that it was specific to one account.

Indeed, I can't reproduce this bug either; tried extensions lst, rty, aaa: all fine.

Perhaps only happens on Windows?

Comment 7

[Alfred Peters [:infofrommozilla]]

Attachment: Bug1729632.eml Mail with Attachments (.lst .log and .7z)

STR (TB91.1.1/Trunk):

• Drop this email into a TB folder (IMAP, POP3 or local doesn't matter)
• Start a new email through 'Forward Inline' or 'Edit As New'
• Check the temp folder or hover the mouse cursor over the attachment icon

As comment 0 describes it, the temporary files now have a different name.

I must admit that I had never sent the mail until now. There the correct name is used again.
So maybe WONTFIX?

The only flaw is that when I drag and drop one of the attachment icons from the compose window into a file folder, the temporary file name is used.

Comment 8

[adrien.rybarczyk]

The problem is that the sender cannot check his attachments before sending if the extension has been renamed (extension changes may lead to modifications in the file), which is a problem when you have to be sure all that everything is OK in your mail before sending.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1729632 - use original file extension for temporary nsmail attachments. r=benc

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/84a052d7dbca
use original file extension for temporary nsmail attachments. r=benc

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9253196 [details]
Bug 1729632 - use original file extension for temporary nsmail attachments. r=benc

[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: for some cases, opening a file attached, during composition, will "not be possible"
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): should be safe

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9253196 [details]
Bug 1729632 - use original file extension for temporary nsmail attachments. r=benc

[Triage Comment]
Approved for esr91

Walt, Rob, we will want to have good testing on the release candidate around attachment handling

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/93430b462333

Comment 14

[WaltS48 [:walts48]]

Attachment handling looks okay to me using the 91.4.1 release candidate on Windows 10.

Viewed the .lst and .log files in Notepad when composing a forwarded message.

I think the reporter should let use know how it works for them when they update before verifying the fix.

Comment 15

[adrien.rybarczyk]

It works, thank you very much.

Comment 16

[WaltS48 [:walts48]]

Verified by the reporter. Thanks!