Closed Bug 1729717 Opened 3 years ago Closed 3 years ago

Remove unused mCache1Dir from CacheStorageService.cpp

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: valentin, Assigned: valentin)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

No description provided.

mCache1Dir is never set. The code that touched it was removed along with
appcache. Since it does nothing we can just remove it.

Attachment #9240056 - Attachment description: Bug 1729717 - Remove unused mCache1Dir from CacheStorageService.cpp r=#necko → Bug 1729717 - Remove unused CleanupCacheDirectories runnable r=#necko
Attachment #9240056 - Attachment description: Bug 1729717 - Remove unused CleanupCacheDirectories runnable r=#necko → Bug 1729717 - Remove unused CleanupCacheDirectories r=#necko
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/92e06bd625c9
Remove unused CleanupCacheDirectories r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/7123efe825f0
Remove unused nsDeleteDir helpers r=necko-reviewers,dragana

Backed out for causing failures on CacheObserver.cpp

[task 2021-09-13T09:37:10.815Z] 09:37:10     INFO - GECKO(2775) | Assertion failure: false (Missing observer handler), at /builds/worker/checkouts/gecko/netwerk/cache2/CacheObserver.cpp:245
[task 2021-09-13T09:37:10.818Z] 09:37:10     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2021-09-13T09:37:16.922Z] 09:37:16     INFO - GECKO(2775) | #01: mozilla::net::CacheObserver::Observe(nsISupports*, char const*, char16_t const*) [netwerk/cache2/CacheObserver.cpp:245]
[task 2021-09-13T09:37:16.922Z] 09:37:16     INFO - GECKO(2775) | #02: nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverList.cpp:69]
[task 2021-09-13T09:37:16.923Z] 09:37:16     INFO - GECKO(2775) | #03: nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverService.cpp:291]
[task 2021-09-13T09:37:16.923Z] 09:37:16     INFO - GECKO(2775) | #04: NS_InvokeByIndex [/opt/worker/tasks/task_163152328749289/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL + 0x1db91e]
[task 2021-09-13T09:37:16.923Z] 09:37:16     INFO - GECKO(2775) | [Child 2777, IPC I/O Child] WARNING: [565499F56599F170.59E80748975F554A]: Ignoring message 'EVENT_MESSAGE' to peer 1.1 due to a missing broker: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:297
Flags: needinfo?(valentin.gosu)
Flags: needinfo?(valentin.gosu)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/02281829cafc
Remove unused CleanupCacheDirectories r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/1819466dd62b
Remove unused nsDeleteDir helpers r=necko-reviewers,dragana
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: