1729732 - ./mach build errors with TypeError: 'NoneType' object is not iterable

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mynacol]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Basically following https://firefox-source-docs.mozilla.org/setup/linux_build.html on a fresh Ubuntu 20.04.

Actual results:

On ./mach build (after the configure step):

TypeError: 'NoneType' object is not iterable

  File "/firefox/mozilla-unified/python/mozbuild/mozbuild/build_commands.py", line 155, in build
    return driver.build(
  File "/firefox/mozilla-unified/python/mozbuild/mozbuild/controller/building.py", line 1194, in build
    for param in self.mozconfig["make_extra"]:

Expected results:

Working compilation of Firefox

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1729732: Undefined `make_extra` shouldn't cause build failures

This was an existing bug that was hidden behind this code path only
being executed for non-make backends.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/025b07e02501
Undefined `make_extra` shouldn't cause build failures r=ahal

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/025b07e02501

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1729383