1729815 - Remove unused ProfilerFeature::Threads

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(Spawned from https://phabricator.services.mozilla.com/D124739#inline-688212 , thanks Florian.)

The help for ProfilerFeature::Threads aka "threads" is "Profile the registered secondary threads". I'm guessing that in the past, only the main thread would be profiled without this explicit feature.
Now this feature is not actually influencing anything anymore! So it should be removed to avoid confusion.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1729815 - Remove unnecessary profiler feature "threads" - r?julienw

This feature doesn't have any effect anymore.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f90cb649f371
Remove unnecessary profiler feature "threads" - r=julienw,perftest-reviewers,AlexandruIonescu

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures on Mutex_posix.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: SUMMARY: AddressSanitizer: SEGV /builds/worker/checkouts/gecko/mozglue/misc/Mutex_posix.cpp:90:3 in mozilla::detail::MutexImpl::~MutexImpl()

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you Cristian.
The profiler did not support an empty features list, nor a feature bitset of 0 (zero). I'll fix that and retest...

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1729815 - Allow empty feature list, or bitset=0 - r?julienw

This is necessary, because the next patch will remove the "threads" feature, and some tests only add that one feature so now they will have an empty feature list, equivalent to a feature bitset of 0 (zero).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c08a6b6ce85a
Allow empty feature list, or bitset=0 - r=julienw
https://hg.mozilla.org/integration/autoland/rev/2198098ce797
Remove unnecessary profiler feature "threads" - r=julienw,perftest-reviewers,AlexandruIonescu

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c08a6b6ce85a
https://hg.mozilla.org/mozilla-central/rev/2198098ce797