Closed Bug 1729850 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30414 - [SelectMenu] Allow the UA provided shadow DOM to be replaced via attachShadow.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30414 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30414
Details from upstream follow.

b'Ionel Popescu <iopopesc@microsoft.com>' wrote:

[SelectMenu] Allow the UA provided shadow DOM to be replaced via attachShadow.

This CL enables authors to replace the UA provided shadow DOM
for \<selectmenu> by calling attachShadow().

For now this change follows the behavior of declarative shadow DOM
where the initial shadow DOM is emptied out and attachShadow returns
a reference to it. There is an open-ui issue1 to further discuss this
behavior.

The initial properties of the UA shadow root are updated with
the ones provided by attachShadow.

Bug: 1121840
Change-Id: I91758022b211fd4c511c0f86997de347c03e6b83
Reviewed-on: https://chromium-review.googlesource.com/3151015
WPT-Export-Revision: 8d0fff6766d9bd776b4797906530ecccf98dbc64

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative.html
Test that the UA provided shadow root can be replaced: FAIL (Chrome: FAIL, Safari: FAIL)
Test that only the UA provided shadow root can be replaced: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0251d76e5769
[wpt PR 30414] - [SelectMenu] Allow the UA provided shadow DOM to be replaced via attachShadow., a=testonly
https://hg.mozilla.org/integration/autoland/rev/4785a3c74c33
[wpt PR 30414] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d92adcc26193
[wpt PR 30414] - [SelectMenu] Allow the UA provided shadow DOM to be replaced via attachShadow., a=testonly
https://hg.mozilla.org/integration/autoland/rev/56fa190b5635
[wpt PR 30414] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d92adcc26193
https://hg.mozilla.org/mozilla-central/rev/56fa190b5635

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.