Closed Bug 1729871 Opened 1 year ago Closed 1 year ago

Add some components to the hybrid build system

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Remove all REQUIRES_UNIFIED_BUILD from js/ since it can be built outside of the unified build system by itself.

Changing severity to NA because it's a build enhancement.

Severity: -- → N/A
Priority: -- → P3

.

Blocks: sm-meta
Priority: P3 → P1

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:andi, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mhentges)
Flags: needinfo?(bpostelnicu)
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b2e412995e6
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges
Flags: needinfo?(mhentges)

Presumably, missing #include "gc/Zone-inl.h" in js/src/gc/Compacting.cpp.

Attachment #9240238 - Attachment description: Bug 1729871 - Add all components from 'js' to the hybrid build system. → WIP: Bug 1729871 - Add all components from 'js' to the hybrid build system.
Attachment #9240238 - Attachment description: WIP: Bug 1729871 - Add all components from 'js' to the hybrid build system. → Bug 1729871 - Add all components from 'js' to the hybrid build system.
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/76a6c8a62862
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d2fed448c0fa
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges
Flags: needinfo?(bpostelnicu)

Backed out changeset d2fed448c0fa (Bug 1729871) for causing build bustages on check_spidermonkey_style.py.
Backout link
Push with failures
Failure Log

Flags: needinfo?(bpostelnicu)
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1364234d0a37
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges
Flags: needinfo?(bpostelnicu)

This seems to cause SpiderMonkey bustages.

Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5a18c0cb270
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges

(In reply to mac198442 from comment #13)

This seems to cause SpiderMonkey bustages.

yes it's a header check script.

Flags: needinfo?(bpostelnicu)

just trying to make it sure it was SpiderMonkey bustages because the tree closure called it build bustages.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.