1729871 - Add some components to the hybrid build system

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Andi [:andi]]

Remove all REQUIRES_UNIFIED_BUILD from js/ since it can be built outside of the unified build system by itself.

Comment 1

[Andi [:andi]]

Attachment: Bug 1729871 - Add all components from 'js' to the hybrid build system.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Changing severity to NA because it's a build enhancement.

Comment 3

[Nicolas B. Pierron [:nbp]]

.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:andi, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b2e412995e6
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing hybrid build bustages. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/70165ca4ce492caea94faa067b7789ddfe113b02
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=9b2e412995e62775bbc37a013354a6c964e25e69&searchStr=hybrid&selectedTaskRun=R8Skd18lT7ekDaoMNqK0dQ.0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=353083485&repo=autoland&lineNumber=81140

Comment 7

[Mike Hommey [:glandium]]

Presumably, missing #include "gc/Zone-inl.h" in js/src/gc/Compacting.cpp.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76a6c8a62862
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on check_spidermonkey_style.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/212ecd89040adccd418a200fee09a2b9ff2a3c11
Log link: https://treeherder.mozilla.org/logviewer?job_id=353543352&repo=autoland&lineNumber=6355

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2fed448c0fa
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges

Comment 11

[Marian-Vasile Laza]

Backed out changeset d2fed448c0fa (Bug 1729871) for causing build bustages on check_spidermonkey_style.py.
Backout link
Push with failures
Failure Log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1364234d0a37
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges

Comment 13

[mac198442]

This seems to cause SpiderMonkey bustages.

Comment 14

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on check_spidermonkey_style.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/d8208898fd846b8587c9367eb77280582ba266a0
Log link: https://treeherder.mozilla.org/logviewer?job_id=353569224&repo=autoland&lineNumber=6355

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5a18c0cb270
Add all components from 'js' to the hybrid build system. r=firefox-build-system-reviewers,mhentges

Comment 16

[Andi [:andi]]

(In reply to mac198442 from comment #13)

This seems to cause SpiderMonkey bustages.

yes it's a header check script.

Comment 17

[mac198442]

just trying to make it sure it was SpiderMonkey bustages because the tree closure called it build bustages.

Comment 18

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e5a18c0cb270