1729990 - Make string changes to about:logins to incorporate "password" terminology

Status: RESOLVED WONTFIX

(Firefox :: about:logins, task)

Description

[Emma Malysz]

In the proclient specs [1], UX has modified some of the strings. Since we are loading about:logins into this panel, we should make these changes in central and merge them into pine.

The proposed changes:
about-logins-confirm-remove-dialog-title: Remove this password?
confirm-delete-dialog-message: This cannot be undone
Remove login-item-save-changes-button and use "save" instead
login-item-cancel-button: Don't save
create-login-button: Add new password

[1] https://www.figma.com/file/434djeTKMELW3ZZNTtEom5?node-id=1698:19010#107410292

Comment 1

[Tim Giles [:tgiles]]

Changing severity to N/A because this is a task.

Comment 2

[Sergey Galich [:serg]]

:jaws do we still want to do this? And if yes, which team is expected to push it?

Comment 3

[Sergey Galich [:serg]]

Emma, do you know who I should talk to about these changes? I'm concerned about replacing "Remove this login?" with "Remove this password?": the "password" is part of the "login". We say "remove password" and then we remove login, not password inside of it. Wouldn't it be misleading?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Sergey Galich from comment #3)

Emma, do you know who I should talk to about these changes? I'm concerned about replacing "Remove this login?" with "Remove this password?": the "password" is part of the "login". We say "remove password" and then we remove login, not password inside of it. Wouldn't it be misleading?

The strings for this should be consistent across both repositories. I agree that the situation you have provided can be confusing. I think it makes more sense to use the strings that are already in mozilla-central in Pro Client.

Comment 5

[Sergey Galich [:serg]]

Shall we close this bug then? It's marked as P1 for 5 months, clearly it's not P1.

Comment 6

[Sergey Galich [:serg]]

Closing it as there is nothing actionable at the moment.