1730017 - Save to Pocket button in newtab Pocket cards

Status: VERIFIED FIXED

(Firefox :: Pocket, enhancement)

Description

[Scott [:thecount] Downe]

This is going to start as an experiment, to see the impact of a more prominent save button in cards might have to saves overall.

A theory for this being people could save multiple interesting stories and read 1 instead of just reading 1, or save multiple interesting stories and then search.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1730017 - Adding save to Pocket button to newtab Pocket cards on hover.

Comment 2

[Scott [:thecount] Downe]

To test:

1. Set browser.newtabpage.activity-stream.discoverystream.saveToPocketCard.enabled to true
2. Also probably want to set browser.newtabpage.activity-stream.discoverystream.compactLayout.enabled to true too.
3. Open a new tab.
4. Hover over a card. EXPECTED: Should see a save to pocket button in the thumbnail, centred, and the meatball menu next to it.
5. Open the meatball menu. EXPECTED: Should open a menu the same as before, cept the save to Pocket item is now missing.
6. Click the save to pocket button in the card. EXPECTED: Should open the Pocket signup panel.
7. Sign in to Pocket.
8. Click the save to pocket button in the card. EXPECTED: Should update the button status to saved, and should also now be saved in your Pocket account.
9. Set browser.newtabpage.activity-stream.discoverystream.saveToPocketCard.enabled back to false.
10. Open newtab.
11. Menu and buttons should now be back to the normal experience.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea872e0652de
Adding save to Pocket button to newtab Pocket cards on hover. r=fluent-reviewers,flod,gvn

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/ea872e0652de

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

This enhancement is implemented and working as expected(based on comment 2) on Firefox 98(20220304153049) and Nightly 99.0a1(20220307190508).
Edit: Also verified on Firefox 94(20211028161635).
The fix was tested on MacOS 11, Ubuntu 20.04 and a VM-run Win10 64bit.